Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordspace should be underlined #119

Open
r12a opened this issue Feb 5, 2020 · 4 comments
Open

Wordspace should be underlined #119

r12a opened this issue Feb 5, 2020 · 4 comments
Labels
doc:ethi gap i:text_decoration Text decoration & other inline features l:am Amharic l:ti Tigrinya p:basic s:ethi Ethiopic script x:ethi

Comments

@r12a
Copy link
Contributor

r12a commented Feb 5, 2020

This issue is applicable to languages using the Ethiopic script, but the principle probably also applies to a number of archaic scripts.

We are currently investigating whether there is really an issue here.

When underlining a word followed by an ethiopic wordspace, the punctuation should also receive the underline. (See the relevant section in the Ethiopic Layout Requirements doc.)

The CSS Text Decoration spec, Level 4 currently says that text-decoration-skip:spaces would not underline Ethiopic word spaces. This seems like a basic issue.

A test is available for this, but text-decoration-skip:spaces doesn't appear to be supported yet by browsers. The issue may arise when implementations begin to provide support for that value.

@r12a r12a added doc:ethi gap i:text_decoration Text decoration & other inline features p:basic labels Feb 5, 2020
@r12a
Copy link
Contributor Author

r12a commented Feb 5, 2020

The first comment in this issue contains text that will automatically appear in the Ethiopic gap-analysis document as a subsection with the same title as this issue. Any edits made to that comment will be immediately available in the document. Proposals for changes or discussion of the content can be made in comments below this point.

@fantasai
Copy link

text-decoration-skip: spaces isn't on by default, and won't be in the future either, it's opt-in. Given that, are you sure that Ethiopic word spaces should not be underlined even when the author has requested skipping spaces?

@r12a
Copy link
Contributor Author

r12a commented Sep 7, 2022

I've been thinking this through again, and about this being something the content author needs to request. I'm not sure that there's an issue here.

Ethiopic wordspace is underlined by default when text-decoration:underline is applied to some text (by all browser engines).

The question is, if the content author then goes on to also apply text-decoration-skip-spaces:all|start|end, which removes the underline from below spaces, should the underline also be removed from below the wordspace? It seems to me that if the author applies skip-spaces to Ethiopic text with wordspace separators, it's probably because they want to remove the underline from below the wordspace, no? If they don't want that to happen, then they should just not apply skip-spaces to the text.

@dyacob what do you think.

@dyacob
Copy link
Member

dyacob commented Sep 8, 2022

@r12a Your take seems most natural regarding the expectation when using skip-spaces applied over text with the Ethiopic wordspace.

Not to complicate things, but... I believe an author using skip-spaces is primarily desiring that only words (letters) be underlined. Thus the wish is also to not underline Ethiopic Comma, Semicon, etc. that would be formatted (positioned between words) under the same rules as the wordspace. skip-spaces helps to that end, but leaves the author with a bit of manual work to remove the underline from regular punctuation. All a bit hypothetical, as I haven't come into this style in documents using workspace.

@r12a r12a moved this to Issue identified, needing investigation in Gap-analysis pipeline Jun 20, 2024
@r12a r12a added s:ethi Ethiopic script l:am Amharic l:ti Tigrinya labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc:ethi gap i:text_decoration Text decoration & other inline features l:am Amharic l:ti Tigrinya p:basic s:ethi Ethiopic script x:ethi
Projects
Status: Issue identified, needing investigation
Development

No branches or pull requests

3 participants