Define scroll terminology #8272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantasai
force-pushed
the
scroll-terminology
branch
from
0a8ef4a to
1627add
Compare
tabatkins
reviewed
Jan 3, 2023
| and, unless otherwise specified, | ||
| coincides with its [=scroll origin position=]. | ||
| However, the 'align-content' and 'justify-content' properties [[!CSS-ALIGN-3]] | ||
| can be used to change the [=initial scroll position=], |
Member
There was a problem hiding this comment.
Suggested change
| can be used to change the [=initial scroll position=], | |
| can be used to change the [=initial scroll position=]; |
Collaborator
Author
There was a problem hiding this comment.
I think we usually use a comma in this pattern.
tabatkins
reviewed
Jan 3, 2023
tabatkins
approved these changes
Jan 3, 2023
Member
tabatkins
left a comment
tabatkins
left a comment
There was a problem hiding this comment.
Two suggested edits (just typo-fixing), otherwise LGTM
fantasai
force-pushed
the
scroll-terminology
branch
from
1627add to
b324c48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8194 #7303 #7237 and does some additional editorial cleanup.