Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-overflow-3] should -webkit-discard be a valid value for continue? #6842

Closed
gsnedders opened this issue Nov 29, 2021 · 2 comments
Closed
Assignees
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-overflow-3 Current Work

Comments

@gsnedders
Copy link
Member

gsnedders commented Nov 29, 2021

https://drafts.csswg.org/css-overflow-3/#propdef-continue / https://drafts.csswg.org/css-overflow-3/#valdef-continue--webkit-discard

Per the value grammar for continue, -webkit-discard is not a valid value, despite it being set as the value of continue by the -webkit-line-clamp shorthand.

I'm unaware of any other case where a property has a value that can only be set via a shorthand, hence this feels like it's adding an oddity (and quite probably causing extra implementation complexity as a result, for unclear benefit to anyone).

It's also somewhat surprising that a value for continue is defined within the "Limiting Visible Lines: the line-clamp shorthand property" section, without "Fragmentation of Overflow: the continue property" even mentioning that value.

Also, if the computed value of continue is -webkit-discard (via the shorthand), how do we expect continue to serialise? Do we expect it to serialise to an invalid value, or to what?

@gsnedders gsnedders added the css-overflow-3 Current Work label Nov 29, 2021
@frivoal
Copy link
Collaborator

frivoal commented Dec 22, 2021

The spec's intent is that it is a valid value of the continue property, but since it's only there for legacy compat, it's described in a compatibility subsection rather than in the main body of text.

The current write up means it as an editorial tweak to deemphasize that value, but it is still mean to behave perfectly normally, excatly as if it had. But I can see how that's not obvious. I've just pushed an editorial update to that section that hopefully should avoid this confusion. Let me know if that works for you.

frivoal added a commit that referenced this issue Dec 22, 2021
The -webkit- prefixed compat part of line-clamp and related properties
aren't meant to be anything out of ordinary in terms of property
mechanics, cascading, OM, etc. They're defined in a separate section do
deemphasize them, but otherwise behave normally. The previous
description was confusing about that, so this clarifies that.

See #6842
@frivoal frivoal self-assigned this Dec 22, 2021
@gsnedders
Copy link
Member Author

Yeah, I think this works for me.

@frivoal frivoal added Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. and removed Commenter Response Pending labels Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-overflow-3 Current Work
Projects
None yet
Development

No branches or pull requests

2 participants