-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-pseudo-4] [css-highlight-api-1] Integrating custom highlights into css-pseudo-4 #6755
Comments
There's a note at the end of https://drafts.csswg.org/css-pseudo-4/#highlight-selectors saying
I'd suggest updating the note to point to css-highlight-api-1, but keeping the two specs separate, at least for now, as they are maturing at different speeds. There are many more things than highlights in css-pseudo, and we should be able to enter (and exit) CR for css-highlight-api-1 faster if we don't tie it to the rest of css-pseudo-4. |
@frivoal They kinda depend on each other, right? The highlight API doesn't do a whole lot if you can't paint the highlights you're defining. Cross-referencing the specs seems fine. |
… css-pseudo-4 #6755 Co-authored-by: fantasai <[email protected]>
@dandclark I merged your PR and added some tweaks. @sanketj would you mind looking things over, and adjusting as you see fit? |
@fantasai @dandclark The updates LGTM, thanks! |
Should the custom
::highlight
pseudos be mentioned among the other highlight pseudos defined at https://drafts.csswg.org/css-pseudo-4/#highlight-selectors?Custom highlights are different from the other pseudos in that they have their own standalone spec, but it seems like there should be at least a note about them in [css-pseudo-4] where the other highlight pseudos are covered.
I attempted to integrate them here: #6754. Not sure if that is the right approach.
cc @sanketj @frivoal
The text was updated successfully, but these errors were encountered: