Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mediaqueries] display mode media feature #6343

Closed
frivoal opened this issue Jun 3, 2021 · 6 comments · Fixed by w3c/manifest#1022
Closed

[mediaqueries] display mode media feature #6343

frivoal opened this issue Jun 3, 2021 · 6 comments · Fixed by w3c/manifest#1022
Labels
Closed Accepted by CSSWG Resolution mediaqueries-5

Comments

@frivoal
Copy link
Collaborator

frivoal commented Jun 3, 2021 •
edited
Loading

In w3c/manifest#975, @marcoscaceres said:

While the CSS crew is here, somewhat unrelated, but related, could we move "display mode media feature" to MQ5?

The current spec is over here: https://www.w3.org/TR/appmanifest/#the-display-mode-media-feature
Support according to MDN:
Screen Shot 2021-06-03 at 13 39 24
@frivoal
Copy link
Collaborator Author

frivoal commented Jun 3, 2021

I'd say that we should indeed merge it into the main MQ spec.

@frivoal frivoal added the Agenda+ label Jun 3, 2021
@frivoal frivoal mentioned this issue Jun 3, 2021
Open
@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [mediaqueries] display mode media feature, and agreed to the following:

  • RESOLVED: adopt this as a part of MQ
The full IRC log of that discussion <dael> Topic: [mediaqueries] display mode media feature
<dael> github: https://github.com//issues/6343
<dael> florian: Media feature in a non MQ spec. Should it move?
<dael> florian: Currently in [missed] spec. Let's you tell if app is in full screen or normal context or if it has minimal UI
<dael> florian: That exists. I think shipped in everything. I think we should adopt it
<Rossen_> q?
<Rossen_> ack smfr
<dael> TabAtkins: Since it's been shipped it's stable. Happy to pull in. Should at least mention, but I think we can pull in
<TabAtkins> s/[missed]/App Manifest/
<dael> Rossen_: florian have you been engaged to make sure this is their intent?
<dael> florian: Request is coming from them
<dael> Rossen_: Objections to adopt this as a part of MQ
<dael> RESOLVED: adopt this as a part of MQ

@mozilla-apprentice mozilla-apprentice mentioned this issue Jun 9, 2021
Open
@marcoscaceres
Copy link
Member

Great! Let me know if I can be of help in moving stuff over.

frivoal added a commit that referenced this issue Dec 2, 2021
@frivoal
[mediaqueries-5] Import display-modes (#6343)
482479d
frivoal added a commit to frivoal/manifest that referenced this issue Dec 3, 2021
@frivoal
Defer display modes to mediaqueries-5
07ee0dd 
See w3c/csswg-drafts#6343 and
w3c#975 (comment)
frivoal added a commit that referenced this issue Dec 3, 2021
@frivoal
[mediaqueries-5] Security considerations for display-mode
8d4a1c8 
See #6343
frivoal added a commit that referenced this issue Dec 3, 2021
@frivoal
[mediaqueries-5] Export the dfn for display mode
4a20fb4 
Part of #6343
frivoal added a commit to frivoal/manifest that referenced this issue Dec 3, 2021
@frivoal
Defer display modes to mediaqueries-5
dc97419 
See w3c/csswg-drafts#6343 and
w3c#975 (comment)
frivoal added a commit to frivoal/manifest that referenced this issue Dec 3, 2021
@frivoal
Transfer display-mode to mediaqueries-5
951520f 
See w3c/csswg-drafts#6343 and
w3c#975 (comment)
@frivoal frivoal mentioned this issue Dec 3, 2021
Merged
@frivoal
Copy link
Collaborator Author

frivoal commented Dec 3, 2021

Waiting for clarifications in w3c/manifest#1023

@marcoscaceres
Copy link
Member

Looking forward on your thoughts on the proposal in w3c/manifest#1023

@frivoal
Copy link
Collaborator Author

frivoal commented Dec 18, 2021

Publication has happened (since we're no worse off than we were before the transfer), so closing. Will follow up in the other issue.

@frivoal frivoal closed this as completed Dec 18, 2021
marcoscaceres pushed a commit to w3c/manifest that referenced this issue Dec 18, 2021
@frivoal
Transfer display-mode to mediaqueries-5 (#1022)
874996c 
See w3c/csswg-drafts#6343 and
#975 (comment)
@mgiuca mgiuca mentioned this issue May 25, 2022
Closed
mgiuca added a commit to mgiuca/manifest that referenced this issue May 25, 2022
@mgiuca
Move the definition of display-mode back to APPMANIFEST.
57bbafb 
Closes w3c/csswg-drafts#7306.

This text was moved out of the Manifest spec into CSS mediaqueries-5 in
w3c/csswg-drafts#6343, along with the display-mode media feature. The
actual definition of display mode belongs here, while the display-mode
media feature remains in CSS mediaqueries-5.
mgiuca added a commit to mgiuca/csswg-drafts that referenced this issue May 25, 2022
@mgiuca
Move the definition of display-mode back to APPMANIFEST. Closes w3c#7306
eefaf27 
.

This text was moved out of the Manifest spec into CSS mediaqueries-5 in
w3c#6343, along with the display-mode media feature. The
actual definition of display mode belongs in Manifest, while the
display-mode media feature remains here.

Added some more text explaining how the display-mode media feature works
given that this is in a separate spec to where web apps are defined.
This was referenced May 25, 2022
Merged
Closed
mgiuca added a commit to mgiuca/csswg-drafts that referenced this issue Nov 4, 2022
@mgiuca
Move the definition of display-mode back to APPMANIFEST. Closes w3c#7306
2f711bd 
.

This text was moved out of the Manifest spec into CSS mediaqueries-5 in
w3c#6343, along with the display-mode media feature. The
actual definition of display mode belongs in Manifest, while the
display-mode media feature remains here.

Added some more text explaining how the display-mode media feature works
given that this is in a separate spec to where web apps are defined.
mgiuca added a commit to mgiuca/manifest that referenced this issue Nov 4, 2022
@mgiuca
Move the definition of display-mode back to APPMANIFEST.
45608b7 
Closes w3c/csswg-drafts#7306.

This text was moved out of the Manifest spec into CSS mediaqueries-5 in
w3c/csswg-drafts#6343, along with the display-mode media feature. The
actual definition of display mode belongs here, while the display-mode
media feature remains in CSS mediaqueries-5.
mgiuca added a commit to mgiuca/manifest that referenced this issue Jan 20, 2023
@mgiuca
Move the definition of display-mode back to APPMANIFEST.
7b97f21 
Closes w3c/csswg-drafts#7306.

This text was moved out of the Manifest spec into CSS mediaqueries-5 in
w3c/csswg-drafts#6343, along with the display-mode media feature. The
actual definition of display mode belongs here, while the display-mode
media feature remains in CSS mediaqueries-5.
mgiuca added a commit to mgiuca/manifest that referenced this issue Apr 21, 2023
@mgiuca
Move the definition of display-mode back to APPMANIFEST.
979e3e6 
Closes w3c/csswg-drafts#7306.

This text was moved out of the Manifest spec into CSS mediaqueries-5 in
w3c/csswg-drafts#6343, along with the display-mode media feature. The
actual definition of display mode belongs here, while the display-mode
media feature remains in CSS mediaqueries-5.
mgiuca added a commit to mgiuca/manifest that referenced this issue Nov 16, 2023
@mgiuca
Move the definition of display-mode back to APPMANIFEST.
758f23e 
Closes w3c/csswg-drafts#7306.

This text was moved out of the Manifest spec into CSS mediaqueries-5 in
w3c/csswg-drafts#6343, along with the display-mode media feature. The
actual definition of display mode belongs here, while the display-mode
media feature remains in CSS mediaqueries-5.
mgiuca added a commit to mgiuca/csswg-drafts that referenced this issue Nov 16, 2023
@mgiuca
Move the definition of display-mode back to APPMANIFEST. Closes w3c#7306
e454100 
.

This text was moved out of the Manifest spec into CSS mediaqueries-5 in
w3c#6343, along with the display-mode media feature. The
actual definition of display mode belongs in Manifest, while the
display-mode media feature remains here.

Added some more text explaining how the display-mode media feature works
given that this is in a separate spec to where web apps are defined.
mgiuca added a commit to mgiuca/csswg-drafts that referenced this issue Feb 26, 2024
@mgiuca
Move the definition of display-mode back to APPMANIFEST. Closes w3c#7306
e313f31 
.

This text was moved out of the Manifest spec into CSS mediaqueries-5 in
w3c#6343, along with the display-mode media feature. The
actual definition of display mode belongs in Manifest, while the
display-mode media feature remains here.

Added some more text explaining how the display-mode media feature works
given that this is in a separate spec to where web apps are defined.
mgiuca added a commit to mgiuca/manifest that referenced this issue Feb 26, 2024
@mgiuca
Move the definition of display-mode back to APPMANIFEST.
4d41b84 
Closes w3c/csswg-drafts#7306.

This text was moved out of the Manifest spec into CSS mediaqueries-5 in
w3c/csswg-drafts#6343, along with the display-mode media feature. The
actual definition of display mode belongs here, while the display-mode
media feature remains in CSS mediaqueries-5.
marcoscaceres added a commit to w3c/manifest that referenced this issue Apr 12, 2024
@mgiuca @marcoscaceres @aarongustafson
editorial: Move the definition of display-mode back to APPMANIFEST. (#…
a791201 
…1039)

* Move the definition of display-mode back to APPMANIFEST.

Closes w3c/csswg-drafts#7306.

This text was moved out of the Manifest spec into CSS mediaqueries-5 in
w3c/csswg-drafts#6343, along with the display-mode media feature. The
actual definition of display mode belongs here, while the display-mode
media feature remains in CSS mediaqueries-5.

* Apply suggestions from code review

Co-authored-by: Aaron Gustafson <[email protected]>

* Tidy.

* display-mode: Rewrite note about display-mode media feature to helpfully point towards the CSS spec.

Also linkify display-mode properly.

---------

Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Aaron Gustafson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted by CSSWG Resolution mediaqueries-5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transfer display-mode to mediaqueries-5 frivoal/manifest
3 participants
@frivoal @marcoscaceres @css-meeting-bot