-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-flexbox][css-grid] order property definition only mentions "flex items" #5865
Comments
Maybe it should even be moved out of the Flexbox specification into one, which both specs refer to, maybe extend CSS Box Alignment's scope to cover it, or a totally new one that also includes But I agree that as a first step, the Flexbox definition should include that it also applies to grid items. Sebastian |
CSS Display might be another candidate for the property, maybe a better fit than a stacking context or alignment spec. |
To me, alignment seems a slightly better choice than display spec, because the behavior of |
|
The CSS Working Group just discussed
The full IRC log of that discussion<fantasai> Topic: Order property definition<fantasai> github: https://github.com//issues/5865 <fantasai> TabAtkins: Brought up that the definition of order only mentions flex items, but also applies to other layout modes (grid at least) <fantasai> TabAtkins: so we should be generalizing this property, but then where should it live? <fantasai> TabAtkins: We think Display is the most appropriate place for it <rachelandrew> +1 for display <fantasai> TabAtkins: Would like resolution to move it to Display, unless someone has a better idea <fantasai> Rossen_: Feedback or other opinions? <fantasai> smfr: Seems fine <emilio> Display or maybe position sounds good <fantasai> Rossen_: objections? <fantasai> RESOLVED: Move order property to Display module |
In the discussion participants were biased by initially mentioning Display as the preferred spec. The alternatives (Alignment, Box, new spec.) were not discussed. I don't have a strong opinion on that topic, though when making a decision all options should be considered. Sebastian |
Alignment is about the positioning of boxes relative to their containing blocks, and CSS Box Model focuses on margins and paddings and defining the various box areas. I don't think CSS Display focuses on the construction of the box tree, and Note the +1 from @rachelandrew, who teaches this stuff. If she felt it was an uncertain fit, I think she would not have marked +1. |
@fantasai Thank you for the explanation for why you decided moving it to the Display module! I previously wrote to extend the Alignment module to move it there, as I thought it would fit best there, or create a completely new spec. for it, but anyway, your explanation is fine for me. Sebastian |
Fixed in 0259f1f |
…and some explanation). Move flexbox example back to flexbox. #5865
I was looking for the list of elements to which the "order" CSS property applies to, and the only one I found was https://www.w3.org/TR/css-flexbox/#order-property
It says
order
"Applies to: flex items", butorder
also applies to grid items (per https://www.w3.org/TR/css-grid/#order-property). Maybe the property definition should be updated to mention it also applies to grid items?The text was updated successfully, but these errors were encountered: