Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-multicol] column-gap <length-percentage> remove at-risk marker #3988

Closed
rachelandrew opened this issue May 30, 2019 · 1 comment
Closed
Assignees
Labels
css-multicol-1 Current Work

Comments

@rachelandrew
Copy link
Contributor

In #1321 <length-percentage> was added to multicol and defined as at-risk.

For the sake of having column-gap be the same everywhere, and as it does appear that Firefox and Chrome have both implemented percentages for multicol column-gap, it seems as if we could remove the at-risk marker.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed Remove at-risk marker for percentages in column-gap, and agreed to the following:

  • RESOLVED: remove at-risk percentages on column-gap (and add some tests)
The full IRC log of that discussion <fremy> Topic: Remove at-risk marker for percentages in column-gap
<astearns> github: https://github.com//issues/3988
<fremy> rachelandrew______: there was a resolution before I joined the group to mark percentages in column-gap at risk
<fremy> rachelandrew______: but Firefox implemented it, and now the property applies on grid and flexbox as well
<fremy> rachelandrew______: so they asked if the at-risk could get removed
<fremy> astearns: do we have implementation report?
<fremy> rachelandrew______: yes
<fremy> astearns: does any other implementation want to get it removed?
<fremy> astearns: I assume not since we resolved to allow it?
<fremy> florian: yeah, I'd agree to remove because sometimes implementors are afraid to implement it
<fremy> AmeliaBR: yeah, at-risk should be redefined to be less scary
<fremy> florian: yeah, that's just the name though, the description is already encouraging implementation
<fremy> florian: it would be nice to change the name at the w3c level, but this hasn't happened anymore
<fremy> s/anymore/yet
<fremy> AmeliaBR: do we have tests to back this up?
<fremy> rachelandrew______: yes, and on top of that we have tests for grid as well, where it is implemented
<fremy> astearns: any objection to remove the at-risk commned?
<fremy> iank_: there is only one test, and that is a bit low
<fremy> iank_: we would need tests for intrinsic sizing etc
<fremy> iank_: but I'm ok to remove the at-risk
<fremy> astearns: resolved then
<fremy> RESOLVED: remove at-risk percentages on column-gap (and add some tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-multicol-1 Current Work
Projects
None yet
Development

No branches or pull requests

3 participants