Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WebIDL escaping of includes() method #299

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Remove WebIDL escaping of includes() method #299

merged 1 commit into from
Sep 24, 2019

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Sep 23, 2019 •
edited by pr-preview bot
Loading

"includes" was added to the WebIDL grammar to avoid needing escaping:

https://heycam.github.io/webidl/#prod-OperationName

Fixes #294

Preview | Diff

@inexorabletash
Copy link
Member Author

@asutherland or @aliams - would you please take a look?

aliams
aliams requested changes Sep 23, 2019
View reviewed changes
Copy link

@aliams aliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have some feedback on the changes made to the code examples.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@inexorabletash
Copy link
Member Author

Sorry about that, @aliams - can you rake another look? I accidentally included the changes from #297 in this example.

aliams
aliams approved these changes Sep 24, 2019
View reviewed changes
Copy link

@aliams aliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward to me.

@inexorabletash inexorabletash merged commit d3943e1 into master Sep 24, 2019
@inexorabletash inexorabletash deleted the includes branch March 27, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliams aliams aliams approved these changes

@asutherland asutherland Awaiting requested review from asutherland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No longer need to escape _includes
2 participants
@inexorabletash @aliams