boot: T5739: Fixed password recovery #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a filter used for `sed` during password reset in the
`set_encrypted_password()` function.
Old logic: search between `user username {` and the first line with `}` does not
work for users with extra options in config, like public keys.
New logic: search between `user username {` and the first line with
`encrypted-password` which should cover all possible combinations, except
situations when a password is not presented in a configuration file.
sever-sever
requested review from
a team,
dmbaturin,
sarthurdev,
jestabro,
sever-sever and
c-po
and removed request for
a team
c-po
approved these changes
Nov 14, 2023
jestabro
approved these changes
Nov 14, 2023
|
@Mergifyio backport sagitta |
✅ Backports have been created
|
|
@Mergifyio backport equuleus |
✅ Backports have been created
|
This was referenced Dec 21, 2023
c-po
added a commit
that referenced
this pull request
Dec 21, 2023
boot: T5739: Fixed password recovery (backport #213)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a filter used for
sedduring password reset in theset_encrypted_password()function.Old logic: search between
user username {and the first line with}does not work for users with extra options in config, like public keys.New logic: search between
user username {and the first line withencrypted-passwordwhich should cover all possible combinations, except situations when a password is not presented in a configuration file.