Add Minimal Offscreen Rendering Example #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc0246
reviewed
Jan 9, 2024
There was a problem hiding this comment.
I think you forgot to remove some of the comments from the triangle example. The idea is that only comments specific to the example are present, so these should be removed. It would also be best to very briefly comment how this example differs from the triangle example, for instance commenting the image and readback buffer. As much as a sentence will be enough.
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
marc0246
reviewed
Jan 9, 2024
marc0246
reviewed
Jan 9, 2024
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
marc0246
reviewed
Jan 10, 2024
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
marc0246
reviewed
Jan 10, 2024
marc0246
reviewed
Jan 10, 2024
Co-authored-by: marc0246 <[email protected]>
Co-authored-by: marc0246 <[email protected]>
|
Thank you for the work! |
marc0246
added a commit
that referenced
this pull request
Jan 15, 2024
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
* add offscreen example * cleanup example * more cleanup * typo * fix clippy * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * edits * i'm loosing my marbles * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * formatting * Update examples/offscreen/Cargo.toml Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * cargo fmt * more correct description * import * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> * Update examples/offscreen/main.rs Co-authored-by: marc0246 <[email protected]> --------- Co-authored-by: marc0246 <[email protected]>
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
marc0246
added a commit
that referenced
this pull request
Mar 4, 2024
marc0246
added a commit
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a minimal offscreen rendering example. I spent a few hours stuck on a bug adapting the triangle example before getting here. I hope this will help fill in the mental model of vulkan for future readers by providing a minimal starting point without the complexity of swapchains.
Changelog: