Merged
Conversation
Contributor
|
With the workspace dependencies applying to every crate, this means that all the dependencies are going to be built regardless of which crate you're actually building? |
Contributor
Author
|
What do you mean by "apply to every crate"? |
Contributor
|
Because they are workspace dependencies, they apply to every crate in the workspace? |
Contributor
Author
|
Workspaces don't exist. Only packages inside the workspace. Workspaces themselves don't have dependencies. That's why I'm not sure I understand correctly. |
marc0246
added a commit
to marc0246/vulkano
that referenced
this pull request
Nov 1, 2023
This was referenced Nov 1, 2023
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the examples having their own workspace introduced in #2381, because it turned out to be more trouble than it's worth. It broke the
run_all.shscript because the newtargetdirectory was generated inexamples, also broke the manifest in theexamplesdirectory after thetargetdirectory is generated there.The alternative would have been to create a
.cargo/config.tomlin the root of the repo with atarget-dir = "target"so that both target directories are in the root, but again more trouble than it's worth and it would break the developer's global configs of the target-dir.