0.34.x winit 0.29#2376
Closed
hyultis wants to merge 2 commits intovulkano-rs:masterfrom
hyultis:0.34.X_winit_0.29
Closed
0.34.x winit 0.29#2376hyultis wants to merge 2 commits intovulkano-rs:masterfrom hyultis:0.34.X_winit_0.29
hyultis wants to merge 2 commits intovulkano-rs:masterfrom
hyultis:0.34.X_winit_0.29
Conversation
Contributor
|
Hello, and thank you for the work. Please note that vulkano-win is deprecated. Are you aware of this? |
Author
|
oh, i have not see that, thank |
Contributor
|
I updated our examples to winit 0.29 in #2385 so you can see how it can be done. Specifically this commit shows you how you can use winit 0.29 together with vulkano 0.34. As for this PR, I'm really sorry but I will be closing it, as much as I hate to because I know you put work into it. I added a note in #2381 for the future. Future contributions are always welcome. :) As an aside, if you ever have trouble with vulkano, we have a #support channel on our discord. Or you can open an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update documentation to reflect any user-facing changes - in this repository.
Make sure that the changes are covered by unit-tests.
[ x ] Run
cargo fmton the changes.[ x ] Please put changelog entries in the description of this Pull Request
if knowledge of this change could be valuable to users. No need to put the
entries to the changelog directly, they will be transferred to the changelog
file by maintainers right after the Pull Request merge.
Please remove any items from the template below that are not applicable.
[ x ] Describe in common words what is the purpose of this change, related
Github Issues, and highlight important implementation aspects.
Hello,
This update winit dependency of vulkano-win, i have updated all version of winit_to_surface(), i have tested android, vulkan/x11, win32 (via wine).
Not tested macos/ios.
Changelog: