Skip to content

Conversation

@xiaoland
Copy link

@xiaoland xiaoland commented Dec 8, 2025

Before submitting the PR, please make sure you do the following

Description

Fixes #5200

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation labels Dec 8, 2025
@OrbisK
Copy link
Member

OrbisK commented Dec 9, 2025

I am not sure if this is what we want for our ref composables. Passing a ref/reactive to ref() does normally return the ref/reactive itself directly. Perhaps we should consider a option to make them deep. 🤔

@xiaoland
Copy link
Author

I am not sure if this is what we want for our ref composables. Passing a ref/reactive to ref() does normally return the ref/reactive itself directly. Perhaps we should consider a option to make them deep. 🤔

Maybe this will be helpful: #5115 (comment)

@OrbisK
Copy link
Member

OrbisK commented Dec 10, 2025

I see. However, I think we should only document that this function is shallow, rather than the reactive workaround.

Removed example code for using reactive with refManualReset and clarified its shallow reactivity.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 17, 2025
@xiaoland
Copy link
Author

I see. However, I think we should only document that this function is shallow, rather than the reactive workaround.

I totally agree, add a workaround in official document might confuse or mislead users since this approach might not be the best choice for user.
Therefore I have made changes at commit 9c0da39 , please review it, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG | refManualReset | Does not track deep mutations

3 participants