Skip to content

fix(useStorageAsync): ensure that data is resolved properly #5196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
keeplearning66 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(useStorageAsync): ensure that data is resolved properly #5196

keeplearning66 wants to merge 2 commits into from
+8 −6

Conversation

@keeplearning66
Copy link
Contributor

@keeplearning66 keeplearning66 commented Dec 2, 2025 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

fix #5195

There is already a test case for this scenario--'onReadyByPromise'. But (result) => { expect(result.value).toBe('AnotherValue') } won't execute before or after the modification, so I modified this test case.

Additional context

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 2, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 2, 2025 •
edited
Loading

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@5196

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@5196

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@5196

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@5196

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@5196

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@5196

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@5196

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@5196

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@5196

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@5196

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@5196

commit: 6f070e4

@codecov
Copy link

codecov bot commented Dec 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.34%. Comparing base (8ff6f19) to head (6f070e4).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5196      +/-   ##
==========================================
- Coverage   64.36%   64.34%   -0.03%     
==========================================
  Files         343      343              
  Lines        6587     6582       -5     
  Branches     2014     1996      -18     
==========================================
- Hits         4240     4235       -5     
  Misses       1946     1946              
  Partials      401      401

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@keeplearning66 keeplearning66 marked this pull request as draft December 2, 2025 07:47
@keeplearning66 keeplearning66 marked this pull request as ready for review December 2, 2025 07:59
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Promise returned by useStorageAsync never resolves

1 participant

@keeplearning66