Skip to content

fix(useConfirmDialog): type of onReveal hook argument match type para… #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zenggpzqbx wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(useConfirmDialog): type of onReveal hook argument match type para… #5182

zenggpzqbx wants to merge 6 commits into from
+4 −4

Conversation

@zenggpzqbx
Copy link

@zenggpzqbx zenggpzqbx commented Nov 22, 2025

…meter RevealData

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

type of onReveal hook argument match type parameter RevealData.

fix #5176

Additional context

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 22, 2025
@antfu antfu enabled auto-merge November 26, 2025 01:40
antfu
antfu previously approved these changes Nov 26, 2025
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 26, 2025
OrbisK
OrbisK previously approved these changes Nov 27, 2025
View reviewed changes
@ilyaliao
Copy link
Member

ilyaliao commented Dec 9, 2025

It looks like this would cause a type error here

vueuse/packages/shared/createEventHook/index.ts

Line 63 in 8ff6f19

return Promise.all(Array.from(fns).map(fn => fn(...args)))

auto-merge was automatically disabled December 10, 2025 14:29

Head branch was pushed to by a user without write access

@zenggpzqbx zenggpzqbx dismissed stale reviews from antfu and OrbisK via 4495b90 December 10, 2025 14:29
@zenggpzqbx
Copy link
Author

zenggpzqbx commented Dec 10, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antfu antfu antfu left review comments

@OrbisK OrbisK OrbisK left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG | useConfirmDialog | Wrong reveal/onReveal declaration for array

4 participants

@zenggpzqbx @ilyaliao @antfu @OrbisK