Skip to content

feat(useStorageAsync): allow disabling serializer #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lanxiong-015 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(useStorageAsync): allow disabling serializer #5097

lanxiong-015 wants to merge 1 commit into from

Conversation

@lanxiong-015
Copy link

@lanxiong-015 lanxiong-015 commented Oct 15, 2025 •
edited by 9romise
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

close #5079

Additional context

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request new function labels Oct 15, 2025
@43081j
Copy link
Collaborator

43081j commented Oct 15, 2025

ill wait for other maintainer opinions, but i'm not sure we should do this.

i think we should document that a user can set the serializer to an identity function as a way to apply "no serialization".

we probably shouldn't introduce a standalone option for it, in my opinion.

antfu
antfu reviewed Nov 27, 2025
View reviewed changes
packages/core/useStorage/index.ts
/**
* Custom data serialization
*/
serializer?: Serializer<T>
Copy link
Member

@antfu antfu Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should support serializer: false instead of adding a new option. Otherwise I am ok with this direction.

(and this is not blocking as you can already pass your custom serializer)

antfu
antfu requested changes Nov 27, 2025
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comment above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antfu antfu antfu requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request new function size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

useStorage & useStorageAsync | Allow storing JS values in storage as-is without using a serializer

3 participants

@lanxiong-015 @43081j @antfu