Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useMouse): record the previous scroll value #4244

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

pkc918
Copy link
Contributor

@pkc918 pkc918 commented Sep 22, 2024

Once the mousemove updates the values of x and y, it implies that the current page scroll position will also be recorded to serve as the initial value for the next scrolling calculation.

fix: #4180

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 22, 2024
@leoatfentech
Copy link

Hey, any news on when this PR will be merged to the main branch ?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@antfu antfu added this pull request to the merge queue Nov 19, 2024
Merged via the queue into vueuse:main with commit e8d1189 Nov 19, 2024
8 checks passed

if (window) {
_prevScrollX = window.scrollX
_prevScrollY = window.screenY
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4348
It was my mistake. I'm sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong information for elementY when scrolling
3 participants