Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(computedAsync): type signature #4207

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix(computedAsync): type signature #4207

merged 1 commit into from
Sep 12, 2024

Conversation

ferferga
Copy link
Contributor

@ferferga ferferga commented Sep 6, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Description

When no initial value is provided, the return type was Ref<T> instead of Ref<T | undefined>.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 11, 2024
@antfu antfu added this pull request to the merge queue Sep 12, 2024
Merged via the queue into vueuse:main with commit 45b187a Sep 12, 2024
8 checks passed
@ferferga ferferga deleted the correct-types branch November 7, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alfred-Skyblue Alfred-Skyblue Alfred-Skyblue approved these changes

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferferga @antfu @Alfred-Skyblue