Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useMouseInElement): allow el to be instanceof Element #4189

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

FRSgit
Copy link
Contributor

@FRSgit FRSgit commented Sep 1, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

In version 11 of vueuse the useMouseInElement composable stopped working for SVG elements as it did before. There was instanceof HTMLElement check added which is a bit too strict: instanceof Element is enough and fixes usage in SVG-element use case.

Additional context

The regression was added as a part of this PR.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 1, 2024
@antfu antfu changed the title fix: useMouseInElement require el to be instanceof Element fix(useMouseInElement): allow el to be instanceof Element Sep 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 12, 2024
@antfu antfu added this pull request to the merge queue Sep 12, 2024
Merged via the queue into vueuse:main with commit 4dcc2b7 Sep 12, 2024
8 checks passed
@FRSgit FRSgit deleted the fix/useMouseInElement-test-for-Element branch September 12, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants