Skip to content

Adding the option to select the firestore database #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aronsuarez wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −2
Open

Adding the option to select the firestore database #1645

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d27c83
Add optional database parameter to `useFirestore` function
aronsuarez Nov 18, 2025
8be2d6c
feat(firestore): add overload for useFirestore with direct database s…
aronsuarez Nov 18, 2025
09aa567
Simplify the approach
aronsuarez Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Simplify the approach
  • Loading branch information
@aronsuarez
aronsuarez committed Nov 22, 2025
commit 09aa5670ce231b93dc82cfff923e42d0da848bd4
22 changes: 2 additions & 20 deletions src/firestore/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,24 +111,6 @@ export function useDocument<T>(
* @param database - name of the database
* @returns the Firestore instance
*/
export function useFirestore(database: string): Firestore
export function useFirestore(options: {
name?: string
database?: string
}): Firestore
export function useFirestore(
optionsOrDatabase: string | { name?: string; database?: string }
): Firestore {
if (typeof optionsOrDatabase === 'string') {
return getFirestore(useFirebaseApp(), optionsOrDatabase)
}

if (optionsOrDatabase.database) {
return getFirestore(
useFirebaseApp(optionsOrDatabase.name),
optionsOrDatabase.database
)
}

return getFirestore(useFirebaseApp(optionsOrDatabase.name))
export function useFirestore(name?: string, database?: string): Firestore {
return getFirestore(useFirebaseApp(name), database)
}