docs: update vue-router documentation #1701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Neat! Looks like some formatting is a bit off: Would you mind running Prettier and push again? (We should def ease this process with a precommit hook or similar…) |
Member
Author
|
@afontcu or i was lazy and committed via github 😆 |
Member
|
I never realized It sounds like this should be the default behavior. |
Update documentation to explain differences between using `localVue` and `mocks` and provide examples of the use case for each. A common gotcha with integration testing (which don't stub children) is when using the `mocks` approach the router instance is not available on child components.
blake-newman
force-pushed
the
blake-newman/improve-documentation
branch
from
e2040c3 to
f1b6cda
Compare
afontcu
approved these changes
Oct 1, 2020
Member
Author
|
@lmiller1990 I have created a new issue. Still believe best to document the current behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation to explain differences between using
localVueandmocksand provide examples of the use case for each.A common gotcha with integration testing (which don't stub children) is when using the
mocksapproach the router instance is not available on child components