feat(history): Reset history.current when all apps are destroyed #3298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightnei
changed the title
nightnei
changed the title
Author
|
@posva @joeldenning look at the PR, please |
internettrans
left a comment
internettrans
left a comment
There was a problem hiding this comment.
Looks good, left a few comments.
| } | ||
|
|
||
| teardownListeners () { | ||
| teardown () { |
There was a problem hiding this comment.
If we rename this method, it might make sense to rename the setupListeners method, too.
vue-router/src/history/base.js
Line 251 in dfc2892
posva
requested changes
Aug 22, 2020
src/history/base.js
Outdated
| this.pending = null | ||
| } | ||
|
|
||
| teardown () { |
Member
There was a problem hiding this comment.
I think we can just put everything inside here as I don't think it makes sense to call teardownListeners or resetHistoryState separately
Author
Thank you for your effort of supporting and developing vue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3294