-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize the JSFiddle starter link #4890
Conversation
We have two different JSFiddle starter links here, none of which is the version on Gitter.im (which appears to be more aligned with Vue's coding standard i.e. no root `<body>` tag, spacings and such). Modifying this issue template to use the Gitter.im version instead.
Codecov Report@@ Coverage Diff @@
## dev #4890 +/- ##
====================================
Coverage 100% 100%
====================================
Files 83 83
Lines 3324 3324
====================================
Hits 3324 3324 Continue to review full report at Codecov.
|
Personally, I like to put the vue.js in a script tag so we can easily change versions to check a regression and verify the user is using the latest version. Something like this: http://jsfiddle.net/posva/wsr78d2w/ |
I'm not against it. The whole idea is, we need to stick to only one template, and therefore, one standard. |
@phanan yes, sorry, being too direct 😆 latest
<script src="https://unpkg.com/vue"></script>
latest v1
<script src="https://unpkg.com/vue@1"></script>
fixed version to test regressions
<script src="https://unpkg.com/[email protected]"></script> |
I think so too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update in CONTRIBUTING.md too.
Guys, feel free to push more changes into this as you deem fit, as I (GitHub actually) opened a branch on vue.js repo itself. |
We have two different JSFiddle starter links here, none of which is the version on Gitter.im (which appears to be more aligned with Vue's coding standard i.e. no root
<body>
tag, spacings and such). Modifying this issue template to use the Gitter.im version instead.