Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the JSFiddle starter link #4890

Merged
merged 2 commits into from
Feb 9, 2017
Merged

Standardize the JSFiddle starter link #4890

merged 2 commits into from
Feb 9, 2017

Conversation

phanan
Copy link
Member

@phanan phanan commented Feb 9, 2017

We have two different JSFiddle starter links here, none of which is the version on Gitter.im (which appears to be more aligned with Vue's coding standard i.e. no root <body> tag, spacings and such). Modifying this issue template to use the Gitter.im version instead.

We have two different JSFiddle starter links here, none of which is the version on Gitter.im (which appears to be more aligned with Vue's coding standard i.e. no root `<body>` tag, spacings and such). Modifying this issue template to use the Gitter.im version instead.
@codecov-io
Copy link

codecov-io commented Feb 9, 2017

Codecov Report

Merging #4890 into dev will not change coverage.

@@         Coverage Diff          @@
##            dev   #4890   +/-   ##
====================================
  Coverage   100%    100%           
====================================
  Files        83      83           
  Lines      3324    3324           
====================================
  Hits       3324    3324

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4cf63...8af56e8. Read the comment docs.

@posva
Copy link
Member

posva commented Feb 9, 2017

Personally, I like to put the vue.js in a script tag so we can easily change versions to check a regression and verify the user is using the latest version. Something like this: http://jsfiddle.net/posva/wsr78d2w/

@phanan
Copy link
Member Author

phanan commented Feb 9, 2017

I'm not against it. The whole idea is, we need to stick to only one template, and therefore, one standard.

@posva
Copy link
Member

posva commented Feb 9, 2017

@phanan yes, sorry, being too direct 😆
Yes, I think a single link would be better too and that we should agree on a standard.
I think that having the script at the top is the most flexible and explicit approach:

latest
<script src="https://unpkg.com/vue"></script>
latest v1
<script src="https://unpkg.com/vue@1"></script>
fixed version to test regressions
<script src="https://unpkg.com/[email protected]"></script>

@kazupon
Copy link
Member

kazupon commented Feb 9, 2017

I think that having the script at the top is the most flexible and explicit approach:

I think so too

Copy link
Member

@znck znck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update in CONTRIBUTING.md too.

@phanan
Copy link
Member Author

phanan commented Feb 9, 2017

Guys, feel free to push more changes into this as you deem fit, as I (GitHub actually) opened a branch on vue.js repo itself.

@yyx990803 yyx990803 merged commit a5a0073 into dev Feb 9, 2017
@znck znck deleted the phanan-patch-1 branch February 10, 2017 03:47
@posva posva mentioned this pull request Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants