Skip to content

perf: drop execa #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webfansplz merged 1 commit into from
Oct 16, 2025
Merged

perf: drop execa #964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
perf: drop execa 
We don't actually use it in the main vite package, so that one is an
easy win.

In the electron package, we use it only to launch a well known path,
i.e. we don't use any features of `execa`. So we should be able to
switch to using the built in `child_process` module directly.
  • Loading branch information
@43081j
43081j committed Oct 15, 2025
commit ace0d498bde841e7f16d80157cdaf7424afe71fb
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@
"eslint": "^9.37.0",
"eslint-plugin-format": "^1.0.2",
"eslint-vitest-rule-tester": "^2.2.2",
"execa": "^9.6.0",
"fast-glob": "^3.3.3",
"fs-extra": "^11.3.2",
"jsdom": "^26.1.0",
Expand Down
1 change: 0 additions & 1 deletion packages/electron/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
"@vue/devtools-kit": "workspace:^",
"@vue/devtools-shared": "workspace:^",
"electron": "^36.9.4",
"execa": "catalog:",
"h3": "^1.15.4",
"pathe": "catalog:",
"socket.io": "^4.8.1",
Expand Down
8 changes: 4 additions & 4 deletions packages/electron/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { spawnSync } from 'node:child_process'
import electron from 'electron'
import { execaSync } from 'execa'
import { resolve } from 'pathe'

const appPath = decodeURIComponent(resolve(new URL('../dist/app.cjs', import.meta.url).pathname))
const argv = process.argv.slice(2)

const result = execaSync(electron as unknown as string, [appPath].concat(argv), {
const result = spawnSync(electron as unknown as string, [appPath].concat(argv), {
stdio: 'inherit',
windowsHide: false,
shell: process.platform === 'win32',
})

process.exit(result.exitCode)
process.exit(result.status ?? 0)
1 change: 0 additions & 1 deletion packages/vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
"@vue/devtools-core": "workspace:^",
"@vue/devtools-kit": "workspace:^",
"@vue/devtools-shared": "workspace:^",
"execa": "catalog:",
"sirv": "^3.0.2",
"vite-plugin-inspect": "catalog:",
"vite-plugin-vue-inspector": "^5.3.2"
Expand Down
Loading
Loading