Skip to content

Conversation

@Dan33l
Copy link
Member

@Dan33l Dan33l commented Dec 24, 2021

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

CHANGELOG.md Outdated


\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*
\* *This Changelog was automatically generated by [github_changelog_generator] (https://github.com/github-changelog-generator/github-changelog-generator)*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this weird whitespace?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know. i suppose it is from new version of generator

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this reproducible? I have not seen this on other releases and the changelog generator gem was updated in thebpast half year.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i run it twice i am getting same result.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous release of module was done in march 2020. The credit was modified in generator april 2020 : github-changelog-generator/github-changelog-generator#794

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird. It's almost as if <<~CREDIT isn't interpreted correctly. Which Ruby version are you using?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.5.3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this return for you?

$ bundle exec pry
/usr/share/ruby/irb/ruby-lex.rb:123: warning: already initialized constant RubyLex::ERROR_TOKENS
/usr/share/gems/gems/irb-1.3.5/lib/irb/ruby-lex.rb:123: warning: previous definition of ERROR_TOKENS was here
[1] pry(main)> require 'github_changelog_generator/generator/generator'
=> true
[2] pry(main)> GitHubChangelogGenerator::Generator::CREDIT_LINE
=> "\\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*\n"

As you can see, there are no odd spaces for me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see there are spaces for me :)
I manually removed them. No time for more.

Hohoho happy Christmas

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change when I run bundle exec rake changelog on top of these changes (after @Dan33l manual updates) with an up-to-date bundle. LGTM.

@Dan33l Dan33l merged commit 6591f48 into voxpupuli:master Dec 25, 2021
@Dan33l Dan33l deleted the release_5_0_0 branch December 25, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants