-
-
Notifications
You must be signed in to change notification settings - Fork 30
release 5.0.0 #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 5.0.0 #129
Conversation
CHANGELOG.md
Outdated
|
|
||
|
|
||
| \* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)* | ||
| \* *This Changelog was automatically generated by [github_changelog_generator] (https://github.com/github-changelog-generator/github-changelog-generator)* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this weird whitespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't know. i suppose it is from new version of generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this reproducible? I have not seen this on other releases and the changelog generator gem was updated in thebpast half year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when i run it twice i am getting same result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous release of module was done in march 2020. The credit was modified in generator april 2020 : github-changelog-generator/github-changelog-generator#794
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's weird. It's almost as if <<~CREDIT isn't interpreted correctly. Which Ruby version are you using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.5.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this return for you?
$ bundle exec pry
/usr/share/ruby/irb/ruby-lex.rb:123: warning: already initialized constant RubyLex::ERROR_TOKENS
/usr/share/gems/gems/irb-1.3.5/lib/irb/ruby-lex.rb:123: warning: previous definition of ERROR_TOKENS was here
[1] pry(main)> require 'github_changelog_generator/generator/generator'
=> true
[2] pry(main)> GitHubChangelogGenerator::Generator::CREDIT_LINE
=> "\\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*\n"As you can see, there are no odd spaces for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you can see there are spaces for me :)
I manually removed them. No time for more.
Hohoho happy Christmas
8cf127f to
2412365
Compare
2412365 to
ca3f190
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change when I run bundle exec rake changelog on top of these changes (after @Dan33l manual updates) with an up-to-date bundle. LGTM.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues