This repository was archived by the owner on Dec 20, 2024. It is now read-only.
Merged
Conversation
ekohl
suggested changes
Jun 4, 2018
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
We do the same on line 14 and 15. Could you do the same there?
Stops the following message from appearing on every catalog compile: `The string '1' was automatically coerced to the numerical value 1`
Contributor
Author
|
Sorry, didn't spot those as they're not in the version of the module we're currently using. Fixed now. |
ekohl
approved these changes
Jun 4, 2018
Member
|
Thanks @bodgit ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Stops the following message from appearing on every catalog compile:
The string '1' was automatically coerced to the numerical value 1Not sure if/how to test this as there's no functional change; it just stops the above appearing in the logs on the Puppetmaster.
This Pull Request (PR) fixes the following issues
n/a