Add vouch.cookie.domain description to allowAllUsers configuration. #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #266
Adding the description of vouch.cookie.domain for 'allowAllUsers: true' config.
This PR is only for the following 2 config examples that directly relate to the issue #266
The configuration test and results are available here on the gist
config/config.yml_example_oidc
To use
allowAllUsers: true
,vouch.cookie.domain
is required instead ofvouch.domains
. The descriptions about this and actualvouch.cookie.domain
config is added to the example.config/config.yml_example
At least in the case with oidc (Okta), setting both
allowAllUsers: true
andvouch.domains
are not allowed. For the case withallowAllUsers: true
, the description ofvouch.cookie.domain
is added as a reminder.There are several config examples with
allowAllUsers: true
that may need to be reviewed.They are excluded from this PR because of some other issues (e.g. the example fails when starting vouch-proxy) and the lack of testing environment.