Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vouch.cookie.domain description to allowAllUsers configuration. #279

Closed
wants to merge 3 commits into from
Closed

Add vouch.cookie.domain description to allowAllUsers configuration. #279

wants to merge 3 commits into from

Conversation

yaws-k
Copy link

@yaws-k yaws-k commented Jun 14, 2020

Related to #266

Adding the description of vouch.cookie.domain for 'allowAllUsers: true' config.

This PR is only for the following 2 config examples that directly relate to the issue #266

The configuration test and results are available here on the gist

  • config/config.yml_example_oidc
  • config/config.yml_example

config/config.yml_example_oidc

To use allowAllUsers: true, vouch.cookie.domain is required instead of vouch.domains. The descriptions about this and actual vouch.cookie.domain config is added to the example.

config/config.yml_example

At least in the case with oidc (Okta), setting both allowAllUsers: true and vouch.domains are not allowed. For the case with allowAllUsers: true, the description of vouch.cookie.domain is added as a reminder.

There are several config examples with allowAllUsers: true that may need to be reviewed.

  • config.yml_example_adfs
  • config.yml_example_gitea
  • config.yml_example_github
  • config.yml_example_github_enterprise
  • config.yml_example_homeassistant
  • config.yml_example_indieauth
  • config.yml_example_nextcloud

They are excluded from this PR because of some other issues (e.g. the example fails when starting vouch-proxy) and the lack of testing environment.

@yaws-k yaws-k changed the title Add vouch.cookie.domain description to allAllUsers configuration. Add vouch.cookie.domain description to allowAllUsers configuration. Jun 16, 2020
@bnfinet
Copy link
Member

bnfinet commented Jun 25, 2020

merged in v0.16.1

@bnfinet bnfinet closed this Jun 25, 2020
@yaws-k yaws-k deleted the issue266 branch June 27, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants