Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nginx_with_vouch needs absolute URI redirect #265

Merged
merged 1 commit into from
May 15, 2020
Merged

fix: nginx_with_vouch needs absolute URI redirect #265

merged 1 commit into from
May 15, 2020

Conversation

bgehman
Copy link
Contributor

@bgehman bgehman commented May 15, 2020

  • use absolute redirect for /login

- use absolute redirect for `/login`
@bgehman
Copy link
Contributor Author

bgehman commented May 15, 2020

@bnfinet This is fixing a goof I made in #263 , sorry about the thrashing.

The 302/redirect does need to be absolute -- for the use cases where request initially comes in on a url other than /. For example, https://myserver.example.com/my/cool/stuff/, the redirect should go to https://myserver.example.com/login, not https://myserver.example.com/my/cool/stuff/login

redirecting to the same $scheme and $http_host, is what is needed. I was originally trying to avoid having to hardcode a hostname here, and this is the fix for that. I have tested this working standalone, and behind a downstream http proxy (a Kubernetes Ingress).

Again, sorry for the thrashing :/

@bnfinet bnfinet merged commit 9b16950 into vouch:master May 15, 2020
@bnfinet
Copy link
Member

bnfinet commented May 15, 2020

No problem @bgehman glad you caught it. Thanks for the update.

Nobody bats a 1000 :)

@bgehman
Copy link
Contributor Author

bgehman commented May 15, 2020

Appreciate it 👍

@bgehman bgehman deleted the patch-1 branch May 15, 2020 16:23
bnfinet added a commit that referenced this pull request May 22, 2020
fix: nginx_with_vouch needs absolute URI redirect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants