Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit hook #1306

Merged
merged 9 commits into from
Mar 20, 2023
Merged

Add pre-commit hook #1306

merged 9 commits into from
Mar 20, 2023

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Mar 16, 2023 •
edited
Loading

References

This PR adds a pre-commit hook to Voila to format python and typescript code.

Code changes

User-facing changes

Backwards-incompatible changes

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/voila/pre-commit

@trungleduc trungleduc added this to the 0.5.0 milestone Mar 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023 •
edited
Loading

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 72 <- [74 - 82 - 98] -> 137 63 <- [64 - 69 - 81] -> 100 63 <- [65 - 69 - 81] -> 103 60 <- [63 - 67 - 75] -> 87 2616 <- [2674 - 2704 - 2818] -> 3929 2406 <- [2426 - 2508 - 2516] -> 2726 2659 <- [2692 - 2709 - 2709] -> 2912 2518 <- [2549 - 2628 - 2648] -> 2865 2014 <- [2062 - 2099 - 2205] -> 2539 3260 <- [3329 - 3462 - 3581] -> 3824 4044 <- [4058 - 4076 - 4196] -> 4363 1733 <- [1760 - 1760 - 1880] -> 2136 2881 <- [2939 - 3013 - 3042] -> 3265
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed 
--- /dev/fd/63	2023-03-20 11:10:08.397534732 +0000
+++ /dev/fd/62	2023-03-20 11:10:08.397534732 +0000
@@ -4,49 +4,49 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8272CL",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 36700160
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "85",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.6,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "7",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281278976
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
       "build": "",
-      "codename": "Jammy Jellyfish",
+      "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1034-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "22.04.2 LTS",
-      "serial": "2eb8d65c617f413abe6f4d67d8f306ea",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@trungleduc trungleduc requested review from martinRenou and jtpio March 16, 2023 23:15
@martinRenou
Copy link
Member

Do we need to enable a bot for this?

jtpio
jtpio reviewed Mar 17, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
jtpio
jtpio reviewed Mar 17, 2023
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@trungleduc
Copy link
Member Author

Do we need to enable a bot for this?

Nope, it is handled by an external service.

jtpio
jtpio reviewed Mar 20, 2023
View reviewed changes
.flake8 Outdated Show resolved Hide resolved
jtpio
jtpio reviewed Mar 20, 2023
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
jtpio
jtpio reviewed Mar 20, 2023
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
martinRenou
martinRenou approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let there be conflicts 🚀

Thanks!

@martinRenou martinRenou merged commit 1ba842f into voila-dashboards:main Mar 20, 2023
@trungleduc trungleduc deleted the pre-commit branch March 20, 2023 12:41
@jtpio jtpio mentioned this pull request Mar 23, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio left review comments

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@trungleduc @martinRenou @jtpio