Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #1193

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Fix CI #1193

merged 4 commits into from
Aug 31, 2022

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Aug 29, 2022 •
edited
Loading

References

Follow up on #1191

Code changes

User-facing changes

Backwards-incompatible changes

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/voila/fix-ci-issue

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022 •
edited
Loading

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 90 <- [93 - 106 - 127] -> 198 87 <- [93 - 101 - 117] -> 154 87 <- [92 - 100 - 117] -> 159 86 <- [91 - 98 - 113] -> 153 2840 <- [2889 - 3058 - 3170] -> 4284 2955 <- [3003 - 3090 - 3333] -> 4000 3043 <- [3085 - 3132 - 3165] -> 3299 3167 <- [3183 - 3298 - 3494] -> 3548 2128 <- [2149 - 2168 - 2194] -> 2366 4648 <- [4735 - 4943 - 5176] -> 5912 11884 <- [11982 - 12233 - 12560] -> 12697 8355 <- [8370 - 8460 - 8489] -> 8563 1397 <- [1603 - 1639 - 1691] -> 1694 2986 <- [3008 - 3061 - 3138] -> 3184
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed 
--- /dev/fd/63	2022-08-29 16:59:26.618703661 +0000
+++ /dev/fd/62	2022-08-29 16:59:26.618703661 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® E5-2673 v4",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
         "l2": 524288,
-        "l3": 52428800
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "79",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.3,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "1",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281307648
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1017-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.4 LTS",
-      "serial": "d6312db80b0c4ba59b8da84ab4b2952b",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@trungleduc trungleduc marked this pull request as ready for review August 29, 2022 17:08
This was referenced Aug 29, 2022
Closed
Closed
jtpio
jtpio reviewed Aug 29, 2022
View reviewed changes
tests/notebooks/output.ipynb
"metadata": {},
"output_type": "display_data"
"output_type": "execute_result"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the diff also includes formatting changes, wondering if this switch of output_type is the one that did the trick?

Copy link
Member Author

@trungleduc trungleduc Aug 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since we are testing against ipywidgets 8, the output of the widgets is now of type execute_result instead of display_data.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks 👍

@trungleduc trungleduc merged commit 249b077 into voila-dashboards:main Aug 31, 2022
@trungleduc trungleduc mentioned this pull request Sep 23, 2022
Closed
martinRenou added a commit that referenced this pull request Sep 23, 2022
@martinRenou
Revert "Fix CI (#1193)"
9195c30 
This reverts commit 249b077.
martinRenou added a commit to martinRenou/voila that referenced this pull request Sep 23, 2022
@martinRenou
Revert "Fix CI (voila-dashboards#1193)"
9530230 
This reverts commit 249b077.
martinRenou added a commit to martinRenou/voila that referenced this pull request Sep 27, 2022
@martinRenou
Revert "Fix CI (voila-dashboards#1193)"
7094906 
This reverts commit 249b077.
martinRenou added a commit to martinRenou/voila that referenced this pull request Sep 27, 2022
@martinRenou
Revert "Fix CI (voila-dashboards#1193)"
70fa37b 
This reverts commit 249b077.
martinRenou added a commit to martinRenou/voila that referenced this pull request Sep 27, 2022
@martinRenou
Revert "Fix CI (voila-dashboards#1193)"
ce106da 
This reverts commit 249b077.
martinRenou added a commit to martinRenou/voila that referenced this pull request Sep 30, 2022
@martinRenou
Revert "Fix CI (voila-dashboards#1193)"
ef5fb21 
This reverts commit 249b077.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio left review comments

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trungleduc @jtpio