Skip to content

Translations 2 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tuna2134 merged 2 commits into from
May 19, 2023
Merged

Translations 2 #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
022214f
translations
maamokun May 18, 2023
00839d3
Translations 2
maamokun May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions voicevox/audio_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,17 @@ class Mora:
Attributes
----------
text: str
文字
Text to synthesize
Copy link

@scarletcafe scarletcafe May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mora are returned from /accent_phrases, thus they are already parsed - the text is not parsed again because it is already converted into the other data which the synthesizer actually uses

consonant: str
子音の音素
Start of consonants
Copy link

@scarletcafe scarletcafe May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mora - there is only one consonant.

consonant_length: int
子音の音長
Pronounciation length of consonants
vowel: str
母音の音素
Start of vowels
Copy link

@scarletcafe scarletcafe May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mora - there is only one vowel.

vowel_length: int
母音の音長
Length of vowels
Copy link

@scarletcafe scarletcafe May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have the same wording as the other length attribute.

pitch: int
ピッチ
ピッチ //Pitch of the voice
Copy link

@scarletcafe scarletcafe May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the correct way to do comments in docstrings, and it shouldn't be a comment anyway to match the other fields.

"""

def __init__(self, payload: MoraType):
Expand Down