Added some parts related to /speaker_info endpoint. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuna2134
approved these changes
Mar 21, 2023
Member
tuna2134
left a comment
tuna2134
left a comment
There was a problem hiding this comment.
Thanks for help as!
Please fix these.
tuna2134
approved these changes
Mar 21, 2023
Member
|
I am sorry to send few time. |
tuna2134
requested changes
Mar 21, 2023
tuna2134
requested changes
Mar 21, 2023
AbstractUmbra
previously approved these changes
Mar 21, 2023
AbstractUmbra
left a comment
AbstractUmbra
left a comment
There was a problem hiding this comment.
Some good work here, thank you!
Just the one or two items still remaining from @tuna2134 to be completed!
tuna2134
previously approved these changes
Mar 21, 2023
Member
|
Oops this is request change |
tuna2134
requested changes
Mar 21, 2023
tuna2134
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using your beautifully written wrapper for developing my standalone application, but I also needed to get icons of the characters from the voicevox engine, realized that it was not implemented yet, therefore I tried to implement it following your conventions as much as I could.
If you like it you can edit and and merge with the main, thank you for this great wrapper!!!