Configuration classes modifications for Dynamic API branch alignment#446
Closed
litvinovg wants to merge 14 commits intovivo-project:mainfrom
Closed
Configuration classes modifications for Dynamic API branch alignment#446litvinovg wants to merge 14 commits intovivo-project:mainfrom
litvinovg wants to merge 14 commits intovivo-project:mainfrom
Conversation
Proof of concept for dynapi february sprint (vivo-project#253) * Dynamic API RPC starting point * Use String to store dateTime until a better type defined * instantinate objects independently in configuration bean loader * Modified ontology files * Replace requireXXX with requresXXX in dynamic API ontology * Parse boolean type while loading instances with ConfigurationBeanLoader * Ontology modifications, refactoring. * Added n3 template rdf class * Renamed rpc name set method * Implemented basic support of sparql queries * Current state for discussion * Multiple fixes, added n3 action example * Added typed parameter example, fixed localization tags * Defined rdf class RPC to represent RPC call, defined class to represent REST Resources * Initialize pools with StartupManager * Added draft of REST Endpoint * Added default http method to define a method should be used for rpc execution and also REST custom action * fix: a mistake, Action should have firstStep, next should be an option of OperationalStep * fix: REST custom action names shouldn't be equal to RPC names
Co-authored-by: William Welling <[email protected]> Co-authored-by: Kevin Day <[email protected]> Co-authored-by: Dragan Ivanovic <[email protected]> Co-authored-by: chenejac <[email protected]> correct context path vs servlet path Refactor Integration Tests to use the full word Test. This allows for the tests to be properly picked up and executed. Merge pull request vivo-project#281 from kaladay/dynapi-rpc_endpoint_it_to_itest [3678] Refactor Integration Tests to use the full word Test. Merge branch 'sprint-dynapi-2022-feb-staging' of github.com:vivo-project/Vitro into servlet-path Merge pull request vivo-project#280 from wwelling/servlet-path Correct context path vs servlet path Update of the ontology. Introducing structured parameter types (object and array) rest endpoint corrections and integration tests Updating binding of the ontology to Java classes and n3 test examples.To be in accordance with changes in the ontology. Adding files for primitive types and APIInformation java bean. Adding new line at the end of file and retrieving history of deleted files by using git mv Adding new line at the end of file Merge pull request vivo-project#283 from chenejac/3653_definition_of_the_ontology 3653 definition of the ontology Merge branch 'sprint-dynapi-2022-feb-staging' of github.com:vivo-project/Vitro into 3667-rest-it
use dynapi model instead of full union
moved dynamic-api-implementation.n3 to dynapi model
AbstractPool improvements
fix configuration bean loader log errors
refact: extracted variables to simplify debugging
… as String into methods
endpoint reorganization in progress
tests are passing
test fixes, refactorings, fixed concurrent use of action in DynamicAPIDocumentation
fix model provider
removed unused imports
removed debug statements
remamings
This reverts commit a1473cb.
litvinovg
force-pushed
the
configuration-bean-loader-ported-modifications
branch
from
7c2443c to
b776311
Compare
chenejac
approved these changes
Apr 5, 2024
Contributor
chenejac
left a comment
chenejac
left a comment
There was a problem hiding this comment.
Unit tests are passing.
The code is clear.
However, it includes dynapi ontology elements, therefore I suggest to discuss this once again within committers group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Ported modifications of configuration related classes from Dynamic API branch.
What's new?
Support for new data property types: boolean, integer.
asString Property annotation parameter
Circularity implementation and test
Added tests to check:
Loading boolean data property
Loading integer data property
Loading Resource URI as String
How should this be tested?
Running standard unit test should be enough.
Interested parties
@VIVO-project/vivo-committers