Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESLint #1

Open
vinitshahdeo opened this issue Oct 10, 2019 · 11 comments · May be fixed by #26 or #27
Open

Add ESLint #1

vinitshahdeo opened this issue Oct 10, 2019 · 11 comments · May be fixed by #26 or #27
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Send PR and earn a free t-shirt help wanted Extra attention is needed

Comments

@vinitshahdeo
Copy link
Owner

Linting is the process of checking the source code for Programmatic as well as Stylistic errors.

Adding ESLint will be helpful in identifying some common and uncommon mistakes that are made during coding.

ESLint covers both code quality and coding style issues.

  • Add ESLint to this project.
  • Add scripts in package.json i.e. npm run test-lint should run lint tests.
  • Do not make any changes to other files.

Please refer this.
@vinitshahdeo vinitshahdeo added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest Send PR and earn a free t-shirt labels Oct 10, 2019
@grigori-gru
Copy link

I'll do this

@vinitshahdeo
Copy link
Owner Author

@grigori-gru Yes, please!

@aleoof
Copy link

aleoof commented Oct 10, 2019

I do this but my access is denied

@agarwalaman263 agarwalaman263 mentioned this issue Oct 10, 2019
Open
Camiila23 added a commit to Camiila23/MiniYouTube that referenced this issue Oct 14, 2019
@Camiila23
Add eslint. Issue vinitshahdeo#1
2d5fe6d 
Adding eslint to package.json
@kalpananegi
Copy link

is this issue open?

@vinitshahdeo
Copy link
Owner Author

@kalpananegi Yes, give it a shot or you may look into a few good first issues which are up for grabs.

✅ Link to the repository

@kushal-khare-official
Copy link

is this issue still open? I would like to do this.

@arielhad
Copy link

@vinitshahdeo I have a branch ready but I need permission to create a branch and open the PR

@mvpowers mvpowers linked a pull request Oct 24, 2020 that will close this issue
Open
@mvpowers
Copy link

@aleoof @arielhad You have to create a fork of this repository, make the commits on your fork, push them up, and then create a pull request.

You will not have permission issues anymore because you are the maintainer of the fork.

Here is an article with more information: https://opensource.com/article/19/7/create-pull-request-github

@arielhad
Copy link

arielhad commented Oct 24, 2020 •
edited
Loading

@vinitshahdeo @mvpowers Can you please review my PR:
#27

@arielhad arielhad linked a pull request Oct 24, 2020 that will close this issue
Open
@Akshit42-hue
Copy link

Can I work upon this issue under hacktoberfest @vinitshahdeo

@tanwi1234
Copy link

I have added the ESLint .please review my PR @vinitshahdeo

@PieroNarciso PieroNarciso mentioned this issue Oct 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Send PR and earn a free t-shirt help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add eslint mvpowers/MiniYouTube
Adding Eslint arielhad/MiniYouTube
9 participants
@arielhad @mvpowers @vinitshahdeo @grigori-gru @aleoof @kalpananegi @Akshit42-hue @kushal-khare-official @tanwi1234