Skip to content

installer: Fix default _vimrc settings #6451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

installer: Fix default _vimrc settings #6451

wants to merge 1 commit into from

Conversation

k-takata
Copy link
Member

The installer didn't create the default _vimrc correctly when installed
with the silent install mode (/S).
The silent install mode doesn't call SetCustom and ValidateCustom
functions, so, set the default values in .onInit function.

@k-takata
installer: Fix default _vimrc settings
593c539 
The installer didn't create the default _vimrc correctly when installed
with the silent install mode (`/S`).
The silent install mode doesn't call `SetCustom` and `ValidateCustom`
functions, so set the default values in `.onInit`.
@k-takata k-takata mentioned this pull request Jul 14, 2020
Open
@codecov
Copy link

codecov bot commented Jul 14, 2020 •
edited
Loading

Codecov Report

Merging #6451 into master will increase coverage by 2.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6451      +/-   ##
==========================================
+ Coverage   86.13%   88.16%   +2.03%     
==========================================
  Files         143      144       +1     
  Lines      155706   159329    +3623     
==========================================
+ Hits       134110   140465    +6355     
+ Misses      21596    18864    -2732
Impacted Files Coverage Δ
src/libvterm/src/unicode.c 70.83% <0.00%> (-17.17%) ⬇️
src/ui.c 79.83% <0.00%> (-2.95%) ⬇️
src/xdiff/xemit.c 67.10% <0.00%> (-1.39%) ⬇️
src/spellfile.c 74.81% <0.00%> (-0.98%) ⬇️
src/xdiff/xpatience.c 89.22% <0.00%> (-0.59%) ⬇️
src/libvterm/src/screen.c 58.93% <0.00%> (-0.45%) ⬇️
src/version.c 92.13% <0.00%> (-0.31%) ⬇️
src/if_perl.xs 86.08% <0.00%> (-0.30%) ⬇️
src/gui_xim.c 23.75% <0.00%> (-0.24%) ⬇️
src/xdiff/xhistogram.c 84.00% <0.00%> (-0.22%) ⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bce831...593c539. Read the comment docs.

@brammool brammool closed this in ceb56dd Jul 14, 2020
@k-takata k-takata deleted the installer-fix-default-settings branch July 14, 2020 22:05
janlazo added a commit to janlazo/neovim that referenced this pull request Jul 14, 2020
@janlazo
vim-patch:8.2.1211: removed more than dead code
0e99dc6 
Problem:    Removed more than dead code.
Solution:   Put back the decrement.
vim/vim@8455c5e

N/A patch for version.c:

vim-patch:8.2.1118: condition can never be true, dead code

Problem:    Condition can never be true, dead code.
Solution:   Remove the dead code.
vim/vim@810af5e

vim-patch:8.2.1214: MS-Windows: default _vimrc not correct in silent install mode

Problem:    MS-Windows: default _vimrc not correct in silent install mode.
Solution:   Add the LoadDefaultVimrc macro. (Ken Takata, closes vim/vim#6451)
vim/vim@ceb56dd

vim-patch:8.2.1215: Atari MiNT support is outdated

Problem:    Atari MiNT support is outdated.
Solution:   Nobody responded this code is still useful, so let's delete it.
vim/vim@e3f915d
janlazo added a commit to janlazo/neovim that referenced this pull request Jul 16, 2020
@janlazo
vim-patch:8.2.1211: removed more than dead code
8c8047d 
Problem:    Removed more than dead code.
Solution:   Put back the decrement.
vim/vim@8455c5e

N/A patch for version.c:

vim-patch:8.2.1118: condition can never be true, dead code

Problem:    Condition can never be true, dead code.
Solution:   Remove the dead code.
vim/vim@810af5e

vim-patch:8.2.1214: MS-Windows: default _vimrc not correct in silent install mode

Problem:    MS-Windows: default _vimrc not correct in silent install mode.
Solution:   Add the LoadDefaultVimrc macro. (Ken Takata, closes vim/vim#6451)
vim/vim@ceb56dd

vim-patch:8.2.1215: Atari MiNT support is outdated

Problem:    Atari MiNT support is outdated.
Solution:   Nobody responded this code is still useful, so let's delete it.
vim/vim@e3f915d
janlazo added a commit to janlazo/neovim that referenced this pull request Jul 19, 2020
@janlazo
vim-patch:8.2.1211: removed more than dead code
bb1f06f 
Problem:    Removed more than dead code.
Solution:   Put back the decrement.
vim/vim@8455c5e

N/A patch for version.c:

vim-patch:8.2.1118: condition can never be true, dead code

Problem:    Condition can never be true, dead code.
Solution:   Remove the dead code.
vim/vim@810af5e

vim-patch:8.2.1214: MS-Windows: default _vimrc not correct in silent install mode

Problem:    MS-Windows: default _vimrc not correct in silent install mode.
Solution:   Add the LoadDefaultVimrc macro. (Ken Takata, closes vim/vim#6451)
vim/vim@ceb56dd

vim-patch:8.2.1215: Atari MiNT support is outdated

Problem:    Atari MiNT support is outdated.
Solution:   Nobody responded this code is still useful, so let's delete it.
vim/vim@e3f915d
shlomif pushed a commit to shlomif/neovim that referenced this pull request Jul 30, 2020
@janlazo @shlomif
vim-patch:8.2.1211: removed more than dead code
bff1164 
Problem:    Removed more than dead code.
Solution:   Put back the decrement.
vim/vim@8455c5e

N/A patch for version.c:

vim-patch:8.2.1118: condition can never be true, dead code

Problem:    Condition can never be true, dead code.
Solution:   Remove the dead code.
vim/vim@810af5e

vim-patch:8.2.1214: MS-Windows: default _vimrc not correct in silent install mode

Problem:    MS-Windows: default _vimrc not correct in silent install mode.
Solution:   Add the LoadDefaultVimrc macro. (Ken Takata, closes vim/vim#6451)
vim/vim@ceb56dd

vim-patch:8.2.1215: Atari MiNT support is outdated

Problem:    Atari MiNT support is outdated.
Solution:   Nobody responded this code is still useful, so let's delete it.
vim/vim@e3f915d
farisachugthai pushed a commit to farisachugthai/neovim that referenced this pull request Aug 4, 2020
@janlazo @farisachugthai
vim-patch:8.2.1211: removed more than dead code
fea9e42 
Problem:    Removed more than dead code.
Solution:   Put back the decrement.
vim/vim@8455c5e

N/A patch for version.c:

vim-patch:8.2.1118: condition can never be true, dead code

Problem:    Condition can never be true, dead code.
Solution:   Remove the dead code.
vim/vim@810af5e

vim-patch:8.2.1214: MS-Windows: default _vimrc not correct in silent install mode

Problem:    MS-Windows: default _vimrc not correct in silent install mode.
Solution:   Add the LoadDefaultVimrc macro. (Ken Takata, closes vim/vim#6451)
vim/vim@ceb56dd

vim-patch:8.2.1215: Atari MiNT support is outdated

Problem:    Atari MiNT support is outdated.
Solution:   Nobody responded this code is still useful, so let's delete it.
vim/vim@e3f915d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
installer platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@k-takata