-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Border effect should respect PNG transparency / image shape #266
Comments
kmanaseryan
added a commit
to kmanaseryan/miniPaint
that referenced
this issue
Sep 25, 2021
kmanaseryan
added a commit
to kmanaseryan/miniPaint
that referenced
this issue
Sep 25, 2021
…d nontransparent part of the image
kmanaseryan
added a commit
to kmanaseryan/miniPaint
that referenced
this issue
Sep 25, 2021
…d nontransparent part of the image
kmanaseryan
added a commit
to kmanaseryan/miniPaint
that referenced
this issue
Sep 26, 2021
kmanaseryan
added a commit
to kmanaseryan/miniPaint
that referenced
this issue
Sep 26, 2021
kmanaseryan
added a commit
to kmanaseryan/miniPaint
that referenced
this issue
Sep 26, 2021
kmanaseryan
added a commit
to kmanaseryan/miniPaint
that referenced
this issue
Oct 31, 2021
kmanaseryan
added a commit
to kmanaseryan/miniPaint
that referenced
this issue
Oct 31, 2021
kmanaseryan
added a commit
to kmanaseryan/miniPaint
that referenced
this issue
Nov 19, 2021
- Constract all those points which are alinged on the edges of the image - Constract separate shapes by using the points above - Draw each shape through Canvas line drawing APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thank you for implementing border as an effect! This border implementation is much preferable to the old one.
One problem remains: the border effect does not respect PNG transparency: it only creates a rectangular border around any image, regardless of the image shape. It should work like the drop shadow effect, which respects PNG transparency, and creates a shadow around the particular shape of the image.
See this screenshot comparing miniPaint border effect to Photoshop stroke effect, for the same image: https://i.imgur.com/5qzt1Ml.jpeg
The text was updated successfully, but these errors were encountered: