Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Circle CI #16

Merged
merged 8 commits into from
Jan 9, 2018
Merged

Configure Circle CI #16

merged 8 commits into from
Jan 9, 2018

Conversation

vgaidarji
Copy link
Owner

@vgaidarji vgaidarji commented Jan 7, 2018 •
edited
Loading

Initial integration is done in #9.
Closes #8.

@vgaidarji vgaidarji self-assigned this Jan 7, 2018
@vgaidarji vgaidarji changed the title Configure circle ci Configure Circle CI Jan 7, 2018
@vgaidarji vgaidarji mentioned this pull request Jan 7, 2018
Closed
@vgaidarji vgaidarji force-pushed the configure-circle-ci branch 11 times, most recently from eef96f0 to f9ef855 Compare January 7, 2018 20:16
@vgaidarji vgaidarji force-pushed the configure-circle-ci branch from f9ef855 to 2eae08b Compare January 7, 2018 20:29
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2eae08b on configure-circle-ci into 1939217 on master.

@vgaidarji vgaidarji force-pushed the configure-circle-ci branch 3 times, most recently from d971aee to fdbe8f1 Compare January 7, 2018 21:12
@vgaidarji vgaidarji force-pushed the configure-circle-ci branch from fdbe8f1 to 82b6a25 Compare January 7, 2018 21:18
cpanato
cpanato approved these changes Jan 8, 2018
View reviewed changes
Copy link

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@vgaidarji
Copy link
Owner Author

@cpanato thanks. I'll add few more things to CIRCLE.md and we should be fine with Circle configuration.

@vgaidarji vgaidarji force-pushed the configure-circle-ci branch 2 times, most recently from 56e3a7a to 8731328 Compare January 8, 2018 21:02
@vgaidarji vgaidarji force-pushed the configure-circle-ci branch from 8731328 to b8558da Compare January 9, 2018 06:25
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b8558da on configure-circle-ci into 1939217 on master.

@vgaidarji vgaidarji merged commit d091770 into master Jan 9, 2018
@vgaidarji vgaidarji deleted the configure-circle-ci branch January 9, 2018 06:53
@vgaidarji
Copy link
Owner Author

@cpanato Thanks again for your efforts 👍 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

Assignees

@vgaidarji vgaidarji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgaidarji @coveralls @cpanato