Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tyr OSRM serializer: create bannerInstructions in step #4093

Merged
merged 28 commits into from
Aug 29, 2023

Conversation

eikes
Copy link
Contributor

@eikes eikes commented Apr 28, 2023

Issue

There is a proprietary extension of the OSRM routing format used in the Mabox Navi SDK and MapLibre Navi SDK, both in iOS and Android. These SDKs only work when the bannerInstructions attribute is present in the steps. This PR aims to optionally add the bannerInstructions behind a flag in the request.

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@kevinkreiser
Copy link
Member

excellent, ive been meaning to add this for years to make the output more compatible with the mapbox apis again but never had the time.

@ianthetechie
Copy link
Contributor

Ooh nice. I see this is currently a draft PR. What is still needed to get this into a mergeable state @eikes? Anything we could do to help?

@ianthetechie
Copy link
Contributor

Bump @eikes?

@eikes eikes force-pushed the banner-instructions branch from a78afc1 to 84b4284 Compare June 1, 2023 08:56
@eis-ioki
Copy link

eis-ioki commented Jun 1, 2023

Yes! I am still working on it off and on. A lot of work is figuring out what they mean and how they are constructed. The instructions are more complicated than I thought. I'll submit this PR when I have the sub section of the bannerInstructions figured out, they represent the lane instructions.

@eis-ioki
Copy link

eis-ioki commented Jun 1, 2023

@ianthetechie @kevinkreiser any idea why these CI builds are failing?

@nilsnolde
Copy link
Member

You’ll need to run scripts/format.sh on it. See the contributing guide. There’s another layer with clang-tidy, but that’s usually fine.

@eikes
Copy link
Contributor Author

eikes commented Jun 1, 2023

@nilsnolde running ./scripts/format.sh starts an endless loop of downloading and uncompressing clang++/11.0.0.tar.gz, llvm/11.0.0.tar.gz, clang++/9.0.1.tar.gz and llvm/9.0.1.tar.gz

ubuntu@valhalla:~/valhalla$ sudo bash ./scripts/format.sh
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang-format/11.0.0.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang-format/11.0.0.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/11.0.0.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/11.0.0.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/compiler-rt-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
NOTICE: detected object has of cf4c0f3bd79ccad5d2c3c55994c00e57c72e28e5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/compiler-rt-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxx-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
NOTICE: detected object has of 27cc5a2a4d6e8f5da95148f04f34e523d8bcc0ac, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxx-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libcxxabi-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
NOTICE: detected object has of d466fea40f70aaf0ca118c00fe8a0c0c71b6a82b, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libcxxabi-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/libunwind-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
NOTICE: detected object has of 94ef884bfe0a9b9de491f66885d2f0751e1cefc5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/libunwind-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/openmp-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
NOTICE: detected object has of e1acc19f634ab9ee98c4c3fa59010a601c67c86e, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/openmp-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lld-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
NOTICE: detected object has of a02e33935d89d919b479ad75b34cba399d9fa929, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lld-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-tools-extra-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
NOTICE: detected object has of 464ff6045a4207bdccdfa35c6dc764128ced4d69, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-tools-extra-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/lldb-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
NOTICE: detected object has of 1352cc818f3cc0656ea85a73f1fc6aa7c5078928, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/lldb-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/polly-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
NOTICE: detected object has of 817d893dd350a0c00a017bbb6d4768292d8021c5, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/polly-11.0.0.src.tar.xz
* Building for Platform 'linux/aarch64'...
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/clang++/9.0.1.tar.gz
* Downloading binary package https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* Binary not available for https://mason-binaries.s3.amazonaws.com/linux-aarch64/llvm/9.0.1.tar.gz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/llvm-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
NOTICE: detected object has of 757d35b90c20c9e3dd2c78170685e3e7be2e6ba2, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/llvm-11.0.0.src.tar.xz
* already downloaded https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang-11.0.0.src.tar.xz to /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz
NOTICE: detected object has of 7aeccf031c94614907a11e0ef7ce5cd5d7dab9aa, optionally add this hash to the 'setup_release' function in your script.sh in order to assert this never changes
* uncompressing /home/ubuntu/valhalla/mason_packages/.cache/clang-11.0.0.src.tar.xz

@eikes eikes force-pushed the banner-instructions branch from 24afc8f to b3822e7 Compare June 20, 2023 13:13
@eikes eikes marked this pull request as ready for review June 22, 2023 11:32
@eikes eikes marked this pull request as draft June 22, 2023 11:32
@nilsnolde
Copy link
Member

Just wanna leave a quick thank you, for stepping down the rabbit hole 😄

@eikes
Copy link
Contributor Author

eikes commented Jun 24, 2023

Here is what I can say about the state of this PR and the banner instructions which it creates:

  1. The JSON structure of the bannerInstructions attribute matches what the navigation SDKs expect.
  2. The idea of each banner component is implemented correctly. It shows the information about and the distance to the upcoming maneuver:
    1. The primary banner includes the streeet name / ref and the type of the maneuver
    2. The secondary banner shows the destination if available
    3. The sub banner shows the lane information if available
  3. There is still room for improvement:
    1. I haven't implemented highway shields yet. The mapbox SDK can show highway shields using the mapbox_shield property (why this is not called highway_shields is unclear to me), and they are really nice and helpful, but they need to take the country and highway type into account. I think it's something that can be implemented in a subsequent PR.
    2. Lane instructions are currently only shown towards the end of the step. Maybe they can be helpful along the way of a longer step though. I am not sure if the navigation SDKs even support more than two elements in the bannerInstructions array though.
  4. Verification: The banner instructions work with a recent version of the Mapbox android navigation SDK, I haven't tested it with the MapLibre navigation SDK yet, but I expect it to work with it as well. I will do that too.
  5. It needs more verification, given that people could use this in a real navigation system. I will also do more manual inspection of various types of route descriptions and their maneuvers, such as roundabouts, on- and off-ramps and / or streets without names. I am planning on creating a tool to visually inspect the generated routes with the banners.

Other than that, I am quite happy with the progress so far and the positive feedback I have received here. Much appreciated, thank you!

@eikes eikes marked this pull request as ready for review June 24, 2023 10:12
@eis-ioki
Copy link

eis-ioki commented Jul 4, 2023

Is anyone willing to give me some feedback on this PR?

@kevinkreiser
Copy link
Member

@eikes yes of course! i will be happy to review it as soon as possible. as you have seen we have a lot of things going on at once and there are only really 2 of us with full time jobs so its hard to really pick which thing to review when, very sorry about that. anyway we'll have a look soon. i did read over your last comment from last week and was wondering what you were going to say about the highway shields 😄 you're choice in forgoing them for the time being makes sense to me as they are a permutation nightmare (from recollection). as for the rest of it i'll look at it maybe this evening more likely this weekend

@@ -311,7 +319,6 @@ Directions options should be specified at the top level of the JSON object.
| `exclude_locations` | A set of locations to exclude or avoid within a route can be specified using a JSON array of avoid_locations. The avoid_locations have the same format as the locations list. At a minimum each avoid location must include latitude and longitude. The avoid_locations are mapped to the closest road or roads and these roads are excluded from the route path computation.|
| `exclude_polygons` | One or multiple exterior rings of polygons in the form of nested JSON arrays, e.g. `[[[lon1, lat1], [lon2,lat2]],[[lon1,lat1],[lon2,lat2]]]`. Roads intersecting these rings will be avoided during path finding. If you only need to avoid a few specific roads, it's **much** more efficient to use `exclude_locations`. Valhalla will close open rings (i.e. copy the first coordingate to the last position).|
| `date_time` | This is the local date and time at the location.<ul><li>`type`<ul><li>0 - Current departure time.</li><li>1 - Specified departure time</li><li>2 - Specified arrival time. Not yet implemented for multimodal costing method.</li></li>3 - Invariant specified time. Time does not vary over the course of the path. Not implemented for multimodal or bike share routing</li></ul></li><li>`value` - the date and time is specified in ISO 8601 format (YYYY-MM-DDThh:mm) in the local time zone of departure or arrival. For example "2016-07-03T08:06"</li></ul><br> |
| `out_format` | Output format. If no `out_format` is specified, JSON is returned. Future work includes PBF (protocol buffer) support. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@kevinkreiser
Copy link
Member

should add voice_instructions after we get this reviewed and merged to complete the package 😉

@@ -429,6 +429,54 @@ struct IntersectionEdges {
}
};

// Process 'indications' array - add indications from left to right
json::ArrayPtr lane_indications(std::unique_ptr<valhalla::odin::EnhancedTripLeg_Edge>& prev_edge,
const valhalla::TurnLane* turn_lane) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why pass this by pointer? indeed why pass it at all? in the end you just pull the mask off of it, perhaps its best to just pass the mask to this function by value eg:

Suggested change
const valhalla::TurnLane* turn_lane) {
uint16_t mask) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point! I made it even simpler by changing the signature to:

lane_indications(const bool drive_on_right, const uint16_t mask)

@kevinkreiser
Copy link
Member

@eikes i started looking at this this morning. it would be vastly easier to review if you had a chance to go through the diff and make some comments about the changes and what they are doing/intended to do. i'll keep plugging along but some of the refactoring is hard to make sense of without some guiding commentary from you.

osrm_man->emplace("modifier", modifier);
}
// Roundabout count
if (maneuver.type() == DirectionsLeg_Maneuver_Type_kRoundaboutEnter &&
Copy link
Member

@kevinkreiser kevinkreiser Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so this gets pulled out of the guts of the maneuver function to the top level, seems fair

Copy link
Contributor Author

@eikes eikes Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously nested within the osrm_maneuver part where the maneuver_type was determined. maneuver_type had to become its own function, so it could be reused in the banner_instructions though. This was the only part that affected the osrm_man, so it had to remain a part of the osrm_maneuver function.

Comment on lines +1595 to +1689
// Get incoming and outgoing bearing. For the incoming heading, use the
// prior edge from the TripLeg. Compute turn modifier. TODO - reconcile
// turn degrees between Valhalla and OSRM
uint32_t idx = maneuver.begin_path_index();
uint32_t in_brg = (idx > 0) ? etp.GetPrevEdge(idx)->end_heading() : 0;
uint32_t out_brg = maneuver.begin_heading();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok this got pulled out because the function we call now doesnt have the path so it cant look at the previous edge. kind of a mess but im not sure how to simplify it. i understand you wanted to not have one large osrm_maneuver method but it does kind of spread logic around. no real clean way to do it, either one large method or smaller ones but with state spread around between them ☹️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. And also: both the turn_modifier and osrm_maneuver function utilise the bearing variables in_brg and out_brg. The turn_modifier was pulled out because it is being used in the maneuver_type in the banner_instructions function itself (along with the modifier from the turn_modifier call).

I did all of that in order to not run the same code again when creating the banner_instructions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively I could pass in the valhalla::odin::EnhancedTripLeg etp into the turn_modifier and osrm_maneuver functions retrieve the bearings there. I was not sure if would incur any computation, but it seems to me now that it doesn't... So if you would prefer that, I can do that, it would remove these three variables from the serialize_legs body.

proto/options.proto Outdated Show resolved Hide resolved
@@ -515,3 +515,196 @@ TEST(Standalone, HeadingNumberAutoRoute) {
}
// clang-format on
}

TEST(Standalone, BannerInstructions) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ausführlich, respekt!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised later on that I could have used assert_json_equality(serialized_json, expected_json) instead, but this works too...

@eikes
Copy link
Contributor Author

eikes commented Jul 11, 2023

@eikes i started looking at this this morning. it would be vastly easier to review if you had a chance to go through the diff and make some comments about the changes and what they are doing/intended to do. i'll keep plugging along but some of the refactoring is hard to make sense of without some guiding commentary from you.

@kevinkreiser I am not sure if it really makes sense to comment the individual lines, so here is what I did and why:

In order to create the object for the bannerInstructions some data that is already present in other places in the JSON is repeated. To avoid running the same code multiple times as much as possible, the code which determines the turn_modifier and the maneuver_type is moved into its own method and the result is stored and reused. The same goes for the lane_indication method from the intersections function which is reused to create the lane directions in the sub banner, this code does run twice, but I don't want to mix the intersections code with the sub code. (The only option would be to have an intermediate representation of the lanes, but I don't think it slows things down anyways.)

What the banner_instructions are concerned, I think it's mostly self-explanatory, except for maybe the sub_banner_instruction, in this method I go back from the end of the step through all the edges which have turn_lanes until one is found which doesn't. These lanes are then put into the sub banner. I still need to investigate whether or not it is possible to have more than two bannerInstructions per step, and if so we could provide separate banner instruction along the step if there are multiple lanes involved. The heuristic currently is, that if a step is longer than 400 meters, the sub banner is shown during the last 400 meters, otherwise it becomes a part of the first banner instruction. The construction of the additional banner instruction happens in the banner_instructions method.

@eikes eikes force-pushed the banner-instructions branch from f9c59be to 5e1a6c7 Compare July 13, 2023 17:30
@kevinkreiser
Copy link
Member

@eikes would you mind resolving the conflicts in the changelog. if you are happy with your progress i think we can merge early this week. i had a look over it and i think even if we find things that arent perfect with it its a great start!

@eikes eikes force-pushed the banner-instructions branch from 6bfb19f to fe67903 Compare July 17, 2023 09:36
@eikes
Copy link
Contributor Author

eikes commented Jul 17, 2023

@kevinkreiser I have rebased this branch on to the latest master branch and there are no conflicts now.

eikes and others added 23 commits August 28, 2023 17:53
Co-authored-by: Kevin Kreiser <[email protected]>
… last lane information and pick better primary / secondary banners
…instruction for roundabouts and their exit steps
@eikes eikes force-pushed the banner-instructions branch from effcad3 to 9210c7d Compare August 28, 2023 15:55
@eikes
Copy link
Contributor Author

eikes commented Aug 28, 2023

I implemented the changes (9210c7d) and rebased the whole branch on the master branch once more. This somehow invalidated your review, but I addressed the change requests.

@kevinkreiser kevinkreiser merged commit fe67191 into valhalla:master Aug 29, 2023
@eikes
Copy link
Contributor Author

eikes commented Aug 29, 2023

Sweet! Four months in the making! I am very happy to see this merged. Next up: voiceInstructions !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants