fix: incompatible CLI usage since v5 #246
Conversation
|
@IceCodeNew could you please review the code? |
|
Do you have the authorization to review and merge PR for this repo? Not sure why @IceCodeNew didn't respond. The script is one of the recommended ways to install v2ray on Linux, yet this issue has been out there for a week without actions from maintainers. Kind of abnormal because it's quite critical. |
|
@digglife I sent a PR (digglife#1) to your repository and it is working fine with me :) |
I don't get it. What's the issue you tried to fix with that? |
|
On Wed, Sep 14, 2022 at 10:01:37PM -0700, 朱聖黎 Zhu Sheng Li wrote:
I don't get it. What's the issue you tried to fix with that?
There is no separate v2ctl executable file in v5.
I let it judge whether this file exists so that this content will not be displayed when installing v5:
```
# bash install-release.sh
installed: /usr/local/bin/v2ctl
```
```
# bash install-release.sh --remove
rm: cannot remove '/usr/local/bin/v2ctl': No such file or directory
```
…--
Dct Mei
-----BEGIN PGP PUBLIC KEY BLOCK-----
mDMEXCinkBYJKwYBBAHaRw8BAQdA5H9IxywOaNmJIWhPWmOW373e5qV9B2XX4uaN
8Dj/os60HERjdCBNZWkgPGRjdHhtZWlAeWFuZGV4LmNvbT6IkAQTFggAOAIbAwUL
CQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHsxS+d9vKIOAt27wFC/i3EtytfqBQJg
F24ZAAoJEFC/i3EtytfqTcUA/2n/BRU+vrnhphWMwXLpFG6BNxnm3cKrlVrlGkdz
+Ww2AQDbbodVwahMIIJNZ+Hu2EaOY5yskrGzjlnHuW4qO7eLDLQbRGN0IE1laSA8
ZGN0eG1laUBnbWFpbC5jb20+iHcEMBYIACAWIQR7MUvnfbyiDgLdu8BQv4txLcrX
6gUCYBduMAIdIAAKCRBQv4txLcrX6vHoAQCv5IeimcILSpwX96JpMuigMySY0gNb
71vTQMYjckTRuQD3fd20co+cHvLK5r2QI7MoGc/xHoPudlufl0vv7etfC7g4BFwo
p5ASCisGAQQBl1UBBQEBB0Axr/Hhs7IfrRZIfGH4m6eDLb/eAMMjeOcdQILs1FVH
IwMBCAeIeAQYFggAIBYhBHsxS+d9vKIOAt27wFC/i3EtytfqBQJcKKeQAhsMAAoJ
EFC/i3EtytfqR4IBANEM6wOjfu9kinIYp5pmh9bwZPM3IPBBn8U0zIL7bUUFAQC/
kqhy8LoX1Th4EIugjgvkkCOY60QGIY6yaHPih7xzCA==
=kO/D
-----END PGP PUBLIC KEY BLOCK-----
|
|
@dctxmei Got it. I didn't notice that v2ctl is gone. Thanks! |
v2ctl has been removed since v5, so the script will fail during removing. ``` rm: cannot remove '/usr/local/bin/v2ctl': No such file or directory error: Failed to remove V2Ray. ```
|
Sorry, I've been a bit down lately and haven't been following github. |
No problem. Thanks for your time. Hope you feel better soon! |
fix: incompatible CLI usage since v5 (v2fly#246)
3 participants
CLI interface has been changed since v5, so we need to make the script work for both v4 and v5.
fixes: #243