Skip to content

Add optional groupname to W&B#17781

Closed
Pikus16 wants to merge 15 commits intoultralytics:mainfrom
Pikus16:wandb_groupname
Closed

Add optional groupname to W&B#17781
Pikus16 wants to merge 15 commits intoultralytics:mainfrom
Pikus16:wandb_groupname

Conversation

@Pikus16
Copy link
Contributor

@Pikus16 Pikus16 commented Nov 25, 2024

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced support for Windows compatibility in CI and improved Weights & Biases (W&B) integration features! 🖥️📊


📊 Key Changes

  • CI Workflow Update:

    • Added shell: bash to the CI workflow for better Windows compatibility.
    • Changed pip install to an editable mode (-e .).
  • Weights & Biases Integration:

    • Added a new group option in the configuration (default.yaml), which allows grouping multiple runs together in W&B.
    • Updated W&B callback to appropriately handle the new group parameter.
    • Documentation improved to include usage details for the group option.

🎯 Purpose & Impact

  • Improved Windows Support:

    • Ensures smoother CI pipeline execution on Windows environments. 🪟
  • Enhanced Experiment Management:

    • The new group parameter helps users organize and visualize related experiments better in W&B, improving productivity and collaboration. 📈
    • Clearer documentation simplifies W&B setup for users, making it more accessible. 📖

These updates ensure smoother development workflows and better experiment tracking capabilities! 🚀

@github-actions
Copy link

github-actions bot commented Nov 25, 2024

All Contributors have signed the CLA. ✅
Posted by the CLA Assistant Lite bot.

@UltralyticsAssistant UltralyticsAssistant added the enhancement New feature or request label Nov 25, 2024
@UltralyticsAssistant
Copy link
Member

👋 Hello @Pikus16, thank you for submitting an ultralytics/ultralytics 🚀 PR! This is an automated response to help streamline the review process, and an Ultralytics engineer will also assist soon. Please review the checklist below to ensure a smooth integration of your work:

  • Purpose of PR: Make sure your PR purpose is clearly defined and explained. It looks like you've added an optional group name to the W&B callback for better experiment organization. Great job including key changes and impact in your description! 🎉
  • 🔄 Sync with main: Check that your branch is up-to-date with the main branch of ultralytics/ultralytics. If not, you can update it by clicking the 'Update branch' button or using git pull and git merge main locally.
  • 🟢 Passing CI Checks: Ensure all Ultralytics Continuous Integration (CI) checks are passing. This ensures that your changes integrate well with the current codebase.
  • 📚 Update Documentation: Consider updating the documentation if your changes introduce new behaviors or modify existing ones.
  • 🔍 Testing: Include tests that cover your changes if applicable, and confirm all tests are passing.
  • ✍️ Sign the CLA: Thank you for signing the Contributor License Agreement (CLA). This is important for us to integrate your contributions.
  • ✂️ Minimal Changes: Thanks for keeping the changes minimal and focused on the new W&B group parameter. This helps us review more efficiently.

For more detailed guidance, please refer to our Contributing Guide. Feel free to leave a comment if you have any questions or need further assistance. Thank you for your valuable contribution to Ultralytics! 🚀✨

@Pikus16
Copy link
Contributor Author

Pikus16 commented Nov 25, 2024

I have read the CLA Document and I sign the CLA

@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Skillnoob
Skillnoob previously approved these changes Nov 26, 2024
Copy link
Collaborator

@Skillnoob Skillnoob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the ci failing? Otherwise good change.

@Skillnoob
Copy link
Collaborator

CI was failing because of the GPU CI not installing Ultralytics correctly. Fixed now.

This reverts commit dd981bd.
@Skillnoob
Copy link
Collaborator

Moved the ci fix to #17883

@Pikus16
Copy link
Contributor Author

Pikus16 commented Dec 4, 2024

Just checking if we can merge this in?

@Skillnoob
Copy link
Collaborator

@glenn-jocher

@Pikus16
Copy link
Contributor Author

Pikus16 commented Dec 9, 2024

following up again on this - are we good to merge?

@Skillnoob
Copy link
Collaborator

@Pikus16 have to wait for @glenn-jocher

@Pikus16
Copy link
Contributor Author

Pikus16 commented Jan 23, 2025

just wanted to follow up and see if we can get this merged in?

@glenn-jocher
Copy link
Member

Thank you for following up. The PR is awaiting final review and approval from the maintainers; once that's complete and all checks are verified, it will be merged.

@github-actions
Copy link

👋 Hello there! We wanted to let you know that we've decided to close this pull request due to inactivity. We appreciate the effort you put into contributing to our project, but unfortunately, not all contributions are suitable or aligned with our product roadmap.

We hope you understand our decision, and please don't let it discourage you from contributing to open source projects in the future. We value all of our community members and their contributions, and we encourage you to keep exploring new projects and ways to get involved.

For additional resources and information, please see the links below:

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@github-actions github-actions bot added the Stale Stale and schedule for closing soon label May 19, 2025
@github-actions github-actions bot closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Stale Stale and schedule for closing soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants