fix: #5851 - While setting content directly while using CharacterCount with limit is not obeyed#5862
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…nt with limit is not obeyed ueberdosis#5851
|
@nperez0111 can you please let me know your thoughts / review this please ? |
nperez0111
left a comment
There was a problem hiding this comment.
This looks good! Thanks for the contribution @gethari
|
Hey @nperez0111 , I think I might have caused a side effect because of this, when the charLimit is set, whenever we try to call |
|
That doesn't sound right to me, can you reproduce in a sandbox & prove that it this. Most likely, you are running into something a lot of people do, trying to put html in setContent and thinking it will work exactly as you input it. As a test, could you try doing insertContent which takes a different codepath than setContent |
|
@nperez0111 please find the Sanbox, The size of the content inside |
|
Yea, not sure what is going on here & I don't have time to fix it. Could you open a new issue? What is strange to me is that it feels like appendTransaction should always run so I'm not sure that we need to run the modification in the filter transaction anymore, & just let it be in the appendTransaction instead |
Fixes #5851
2024-11-22.at.16.17.40.-.Tan.Cephalopod.mp4