feat(suggestion): trigger exit when the items are empty#5574
Closed
litingyes wants to merge 1 commit intoueberdosis:developfrom
Closed
feat(suggestion): trigger exit when the items are empty#5574litingyes wants to merge 1 commit intoueberdosis:developfrom
litingyes wants to merge 1 commit intoueberdosis:developfrom
Conversation
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This is not a good idea. Maybe the users want to show empty message (custom UI) for when nothing is found. |
Member
|
Thanks for the PR but I'm closing it as this would break any way to have empty states in suggestion popups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Notes
#5573
Checklist