feat(extension-highlight): add paste rule#5527
Closed
Gregoor wants to merge 1 commit intoueberdosis:developfrom
Closed
feat(extension-highlight): add paste rule#5527Gregoor wants to merge 1 commit intoueberdosis:developfrom
Gregoor wants to merge 1 commit intoueberdosis:developfrom
Conversation
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
|
I know this isn't great yet, @bdbch do you have some guidance for me on how I could make this adequate and mergeable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Overview
This parses out highlight color when pasting
Implementation Approach
I use
DOMParserto look at the clipboard, find span's with non-default bg color and use it for the highlight mark.I use a running counter (
indexAcc) to keep track where I am in the clipboard text, as DOMParser does not come with source maps. Unfortunately I couldn't get that to work with paragraphs in the time that I had, so I just skip them when they are present.Testing Done
None added yet, happy to do so if desired
Verification Steps
npm dev=>http://localhost:3000/preview/Marks/Highlight=> paste some bg highlighted text from Docs/Word/Pages/...Checklist
Related Issues
#5476