Resolves #4089#5515
Closed
haydenbleasel wants to merge 5 commits intoueberdosis:nextfrom
haydenbleasel:develop
Closed
Resolves #4089#5515haydenbleasel wants to merge 5 commits intoueberdosis:nextfrom haydenbleasel:develop
haydenbleasel wants to merge 5 commits intoueberdosis:nextfrom
haydenbleasel:develop
Conversation
🦋 Changeset detectedLatest commit: d9f14a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 55 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for tiptap-embed failed. Why did it fail? →
|
1 task
nperez0111
reviewed
Aug 21, 2024
Comment on lines
+30
to
+40
|
|
||
| it('can convert from & to html', async () => { | ||
| const extensions = [Document, Text, Youtube] | ||
| const html = `<p>Tiptap now supports YouTube embeds! Awesome!</p> | ||
| <div data-youtube-video> | ||
| <iframe src="https://www.youtube.com/watch?v=cqHqLQgVCgY"></iframe> | ||
| </div>` | ||
| const json = generateJSON(html, extensions) | ||
|
|
||
| expect(generateHTML(json, extensions)).to.equal(html) | ||
| }) |
Contributor
There was a problem hiding this comment.
I wish we had more tests to give more confidence here 😓
Member
There was a problem hiding this comment.
Could we get an update here? @haydenbleasel (the branch also needs to get synced with upstream again)
5 tasks
Contributor
|
I couldn't pull this down locally to test it, so I made my changes to get this ready for V3 in this PR, closing here since that will be the one we ultimately merge. Very much appreciate the contribution though @haydenbleasel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Overview
Replaces
zeed-domwithhappy-dom, allowing for parsing of more complex HTML structures.Implementation Approach
Replaced
zeed-domwithhappy-domingenerateJSONandgetHTMLFromFragmentas proposed by @Philipinho.Testing Done
it("can convert from & to html")as proposed by @ben-bourdin451, though haven't validated it yet due to 'Cypress could not verify that this server is running' error with baseUrl in component test after updating to v13 cypress-io/cypress#27990Verification Steps
None
Additional Notes
None
Checklist
Related Issues
#4089 (comment)
#5352