You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Love bun, but I have to be honest that it isn't quite there yet in terms of NPM compatibility, you still will need to use NPM for publishing for example.
Could we maybe stick with pnpm instead, it is 90% the speed of bun, but is a much more mature project, allowing things like overrides & patching packages which is very useful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Overview
This PR moves away from
npmin favor forbunto speed up package resolvement & caching.Implementation Approach
I replaced the package-lock with a new bun.lockb and updated all scripts & Github actions accordingly
Testing Done
I ran builds, the dev setup & linting locally.
Additional Notes
This is not super crucial and needs a bit of testing because of the Github Actions changes.
Checklist