VM Recreate #2193
Closed
VM Recreate #2193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyevans
reviewed
Nov 5, 2024
furkansahin
force-pushed
the
vm_recreate
branch
from
d453baf to
b6842d9
Compare
furkansahin
force-pushed
the
vm_recreate
branch
from
b6842d9 to
09bbf7e
Compare
fdr
reviewed
Nov 7, 2024
furkansahin
force-pushed
the
vm_recreate
branch
3 times, most recently
from
11fc8fe to
e1e1423
Compare
fdr
force-pushed
the
vm_recreate
branch
2 times, most recently
from
da4da1e to
846de1b
Compare
furkansahin
force-pushed
the
vm_recreate
branch
2 times, most recently
from
e9aabfa to
89b31af
Compare
|
@fdr , I squashed your commit. |
fdr
reviewed
Nov 19, 2024
fdr
reviewed
Nov 19, 2024
There was a problem hiding this comment.
that recreate method seems a little smelly, surely it must be duplicating a bunch of stuff as features are added. What's preventing us from looping back to the creation state and not doing quite so much? i.e. why is re-create different enough from "create" as it comes to those resources?
furkansahin
force-pushed
the
vm_recreate
branch
from
89b31af to
37390dd
Compare
|
@fdr , I have moved around some of the code, I think this makes more sense now. The problem I have is that some of the entities we generated need to be destroyed and recreated. We depend on plugins to destroy some of them. That's why the struggle. |
jeremyevans
reviewed
Dec 19, 2024
furkansahin
force-pushed
the
vm_recreate
branch
from
37390dd to
a9fceda
Compare
This pr adds a new logic to Vm::Nexus to be able to recreate a VM. For now, this is only available to the on-call. In case we realize the VM is stuck in the provisioning path, the on-call may simply incr_recreate and force the VM to be recreated including new storage entities, ip configuration, etc. In future, we may automate this process further and even add features like excluding the previously tried host. For now, this is a very basic implementation.
furkansahin
force-pushed
the
vm_recreate
branch
from
a9fceda to
60df930
Compare
|
@fdr @jeremyevans , may I have a round of review? |
jeremyevans
reviewed
Jan 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a new logic to Vm::Nexus to be able to recreate a VM. For
now, this is only available to the on-call. In case we realize the VM is
stuck in the provisioning path, the on-call may simply incr_recreate and
force the VM to be recreated including new storage entities, ip
configuration, etc. In future, we may automate this process further and
even add features like excluding the previously tried host. For now,
this is a very basic implementation.