Add table component to UI #2183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyevans
reviewed
Nov 5, 2024
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
I like how much simpler this makes things.
enescakir
force-pushed
the
table-component
branch
from
cd6bdf7 to
5de6233
Compare
enescakir
force-pushed
the
component-args
branch
from
9111ab2 to
1d5971c
Compare
enescakir
force-pushed
the
table-component
branch
from
5de6233 to
42ccaf8
Compare
enescakir
force-pushed
the
table-component
branch
from
42ccaf8 to
37646b8
Compare
Member
Author
|
I initially planned to convert all the tables at once, but it seems like it's going to take a while and cause conflicts over time. So, I've decided to merge the initial version first and gradually convert all tables. Other team members can also assist with the conversion. |
jeremyevans
approved these changes
Jan 3, 2025
We have many tables to display resources in our UI, and we keep copying and pasting the same code. Some of these tables also have incorrectly copied styles. When we want to make changes to a table, it requires updating multiple places. The new component will help us solve these issues. We have a similar `kv_data_card` component for displaying resource details, and I find it very useful.
enescakir
force-pushed
the
table-component
branch
from
37646b8 to
1194e35
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have many tables to display resources in our UI, and we keep copying and pasting the same code. Some of these tables also have incorrectly copied styles. When we want to make changes to a table, it requires updating multiple places. The new component will help us solve these issues.
We have a similar
kv_data_cardcomponent for displaying resource details, and I find it very useful.