Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure time.Tickers are properly stopped #22

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Ensure time.Tickers are properly stopped #22

merged 1 commit into from
Jun 14, 2017

Conversation

henridevieux
Copy link
Contributor

@henridevieux henridevieux commented Jun 14, 2017 •
edited
Loading

Before opening your pull request, please make sure that you have:

Thanks for your contribution!

@henridevieux henridevieux requested a review from Vasilis June 14, 2017 17:01
Vasilis
Vasilis approved these changes Jun 14, 2017
View reviewed changes
Copy link
Contributor

@Vasilis Vasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, @henridevieux

@henridevieux henridevieux merged commit 005f2b3 into master Jun 14, 2017
@Vasilis Vasilis deleted the timers branch June 14, 2017 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vasilis Vasilis Vasilis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henridevieux @Vasilis