Skip to content

Pin zap to v0 and replace some fatal logs w error #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2017
Merged

Pin zap to v0 and replace some fatal logs w error #10

merged 1 commit into from
Apr 28, 2017

Conversation

henridevieux
Copy link
Contributor

@henridevieux henridevieux commented Apr 28, 2017 •
edited
Loading

Before opening your pull request, please make sure that you have:

Thanks for your contribution!

@henridevieux henridevieux requested a review from Vasilis April 28, 2017 17:25
Vasilis
Vasilis approved these changes Apr 28, 2017
View reviewed changes
Copy link
Contributor

@Vasilis Vasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid points for converting these fatals to errors.

@henridevieux henridevieux merged commit c296ef8 into master Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vasilis Vasilis Vasilis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henridevieux @Vasilis