Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Attributes #466

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Conversation

aestoltm
Copy link
Collaborator

Reconstructed PR(#450) to see how migrations change after refactoring PR(#399) created by @RyanChang0369

@aebruno aebruno requested a review from dsajdak October 27, 2022 12:14
Copy link
Contributor

@dsajdak dsajdak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All previous requests on this PR have been completed and test out well. I have found no other issues with it and think it looks great! Thanks @aestoltm!

@aebruno aebruno merged commit b2443c4 into ubccr:master Nov 8, 2022
knikolla added a commit to knikolla/coldfront-nerc that referenced this pull request Feb 16, 2023
Note:
   Requires running database migrations since it includes new schema.

Among other things, this fixes nerc-project#76, since it corrects the mismatch
between our version of the email templates and coldfront code.

It also includes
- Only Denied sending a signal, now Revoked also does.
ubccr/coldfront#474

- Implements project attributes, which can be really useful.
ubccr/coldfront#466

- Updates the ColdFront logo
ubccr/coldfront#431

Closes nerc-project#76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants